Remove EXPORTS from media/mtransport/standalone

RESOLVED FIXED in mozilla25

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: mshal, Assigned: mshal)

Tracking

unspecified
mozilla25
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
media/mtransport/standalone/moz.build specifies some files in EXPORTS which are a subset of the files in media/mtransport/build/moz.build. Only the ones in build/ are actually used, since that directory is traversed first. Both directories are always enabled in toolkit/toolkit.mozbuild, so I don't think there is a case where we use standalone/ and not build/.
(Assignee)

Comment 1

5 years ago
Created attachment 770409 [details] [diff] [review]
Remove EXPORTS from media/mtransport/standalone
Assignee: nobody → mshal
Attachment #770409 - Flags: review?(gps)

Comment 2

5 years ago
Comment on attachment 770409 [details] [diff] [review]
Remove EXPORTS from media/mtransport/standalone

Review of attachment 770409 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not certain of what's all going on here. There might be some weird webrtc requirement we don't know about. Version control history says jesup should be able to shine some light on the matter.
Attachment #770409 - Flags: feedback?(rjesup)
Comment on attachment 770409 [details] [diff] [review]
Remove EXPORTS from media/mtransport/standalone

Review of attachment 770409 [details] [diff] [review]:
-----------------------------------------------------------------

the mtransport 'standalone' directory is used when building C++ unit tests (sdp_unittests, mediapipeline_unittests, etc)

However, removing these EXPORTS from the moz.build seemed to have no impact on a fresh build of Aurora, so as mentioned they're likely redundant.
Attachment #770409 - Flags: feedback?(rjesup)
Attachment #770409 - Flags: feedback?(ekr)
Attachment #770409 - Flags: feedback+

Comment 4

4 years ago
Comment on attachment 770409 [details] [diff] [review]
Remove EXPORTS from media/mtransport/standalone

Review of attachment 770409 [details] [diff] [review]:
-----------------------------------------------------------------

Works for me.

Now that moz.build has a whole-world view, I suppose we could employ duplication detection. Add this to the list of additional validation we could perform.
Attachment #770409 - Flags: review?(gps) → review+
(Assignee)

Comment 5

4 years ago
try results: https://tbpl.mozilla.org/?tree=Try&rev=e6733af1d713

The reds seem to all be from the service outage, and are green when re-executed.
(Assignee)

Comment 6

4 years ago
inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/286bf38196b0
https://hg.mozilla.org/mozilla-central/rev/286bf38196b0
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25

Updated

4 years ago
Attachment #770409 - Flags: feedback?(ekr)
You need to log in before you can comment on or make changes to this bug.