889580 - Thimble publish button is inconsistently absent

Status: VERIFIED FIXED

(Webmaker Graveyard :: Thimble, defect)

Description

[Brett Gaylor [:brett]]

I'm having trouble pinpointing why, but for me I'm trying to edit and publish this project:

https://brett.makes.org/thimble/the-dude

And the publish button is sometimes absent.  Related, it seems like i am not always logged in.

Comment 1

[Brett Gaylor [:brett]]

I took a screencast of this happening:
https://dl.dropboxusercontent.com/u/7968133/images/no%20publish%20button.mov

You'll see that once I signed in (I HAD been signed in, but somehow became signed out) the publish button reappears.  I then opened a new tab and a new thimble project, and the publish button disappears again.

This is frequent for me.

Comment 2

[Scott [:thecount] Downe]

I tried throttling my connection to 56k and 128k.

It was fairly eye opening, and we should get better here. Slow is slow, but things should still work eventually.

I did have many cases where I saw what Brett is seeing. Enough cases to debug and test this.

I feel much better about this now!

Comment 3

[Brett Gaylor [:brett]]

Great that you've pinpointed the problem.  Agreed we should definitely be better here!  Something to move up the priority queue for certain.

Comment 4

[Pomax]

testing with throttling is a great idea! So does the button "not show" or does it just take an inordinate amount of time to pop up after persona's login finishes?

Comment 5

[Scott [:thecount] Downe]

I left it on while I did other things for a good half hour, never showed.

When it does show, it shows in reasonable time.

Comment 6

[Pomax]

I've also seen thimble attempt a login but fail, with the code actually flipping the "logged in" switch, so you only get "sign out" as text link, but no user information nor a publish button. It is possible we're flipping that switch too early in the persona login chain.

Comment 7

[Kat Braybrooke [:codekat]]

This is also a continuing issue for ThinkBig teams here in the UK, who use Thimble with school kids in Germany, the UK, Spain and Czech Republic. They've all told me in the last few weeks, separately, using very different types of computers and internet connections, that their kids haven't been able to publish because the "publish" button doesn't show up quite often. 

I didn't believe it until I tried publishing a series of makes at a ThinkBig workshop last week, on a set of 25 laptops all with the same (fairly fast) wi-fi connection. The "Publish" button disappeared intermittently and it seemed for no reason (ie, I was logged in, using a bunch of different Makes, and editing differently each time). 

Would be good to figure out why this is happening, because I was stumped!

Comment 8

[Scott [:thecount] Downe]

Attachment: https://github.com/mozilla/thimble.webmaker.org/pull/179

This was bugging me, and obviously others. So I pushed it up my queue.

Kinda needed the change.

Comment 9

[Pomax]

Comment on attachment 778026 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/179

one request, but r+ if you add the comment.

Comment 10

[Scott [:thecount] Downe]

Works for me.

Staged: https://github.com/mozilla/thimble.webmaker.org/commit/d63161e6620982ec94aaebe6c69a17a650ad9d67

Comment 11

[Scott [:thecount] Downe]

I had to revert it.

Causes things to break on staging. It causes the sign out button to never leave.

If you want to simulate what it causes on staging locally, put a good 2 second timeout around "require(["{{userbar}}/js/sso-ux.js"]);"

It seems there is something else that has to be ready after this script, is my guess. Only seems to happen on a refresh while logged in, and not log in/log out.

I think it's exposing something that already exists, which is if an auto log in happens before everything is ready, it fails.

Comment 12

[Scott [:thecount] Downe]

Attachment: https://github.com/mozilla/thimble.webmaker.org/pull/181

Similar to the initial problem, we also need to ensure things are ready before we setup the sso iframe.

Comment 13

[Scott [:thecount] Downe]

This is the backed out patch: https://github.com/mozilla/thimble.webmaker.org/commit/82d199f3c5ebdc06754f07e640b1b528e62fd234

Comment 14

[Pomax]

Comment on attachment 779308 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/181

This looks pretty good to me, although I couldn't really get the timeout to work in a way that broke things. That said, making the iframe source conditional on having sso overrides available is a very sensible idea.

Comment 15

[Scott [:thecount] Downe]

Staged: https://github.com/mozilla/thimble.webmaker.org/commit/4fe6633d7b38fd28825f5ac142fc2c2e65bedd3f

Needs verification.

Comment 16

[Scott [:thecount] Downe]

I think it's safe to say this has not happened in a long time.

We can reopen with new info if we see it again.