889599 - Partial CompileFunctionBody cleanup work

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jason Orendorff [:jorendorff]]

Oh wow CompileFunctionBody is a mess. These 4 patches get rid of a few unnecessary parameters and straight up a bit.

Comment 1

[Jason Orendorff [:jorendorff]]

Attachment: Part 1 - Fix ParseNode.h comment about PNK_FUNCTION nodes.

This comment gets out of date from time to time. Still worth keeping, for now...

Comment 2

[Jason Orendorff [:jorendorff]]

Attachment: Part 2 - Remove unnecessary FunctionBox out-parameter from Parser<>::standaloneFunctionBody.

-1 parameter.

Comment 3

[Jason Orendorff [:jorendorff]]

Attachment: Part 3 - Create function parse nodes in the Parser rather than in frontend::CompileFunctionBody.

-1 parameter.

Comment 4

[Jason Orendorff [:jorendorff]]

...wait for it...

Comment 5

[Jason Orendorff [:jorendorff]]

Attachment: Part 4 - Remove unnecessary script parameter to Parser::standaloneFunctionBody

-1 parameter.

Comment 6

[Jeff Walden [:Waldo]]

Comment on attachment 770443 [details] [diff] [review]
Part 2 - Remove unnecessary FunctionBox out-parameter from Parser<>::standaloneFunctionBody.

Review of attachment 770443 [details] [diff] [review]:
-----------------------------------------------------------------

Well-spotted.

Comment 7

[Jeff Walden [:Waldo]]

(In reply to Jason Orendorff [:jorendorff] from comment #4)
> ...wait for it...

...I can't bear it!

Comment 8

[Jeff Walden [:Waldo]]

Comment on attachment 770448 [details] [diff] [review]
Part 4 - Remove unnecessary script parameter to Parser::standaloneFunctionBody

Review of attachment 770448 [details] [diff] [review]:
-----------------------------------------------------------------

Magnifique!

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/1c161cc86c6b
https://hg.mozilla.org/mozilla-central/rev/74ee51dfddf2
https://hg.mozilla.org/mozilla-central/rev/f461f536d1f3
https://hg.mozilla.org/mozilla-central/rev/3151cc8eb6a0