889602 - directoryService.get "ProfD" not working for B2G mochitests

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[[e-mail] [:onecyrenus]]

ProfD is currently not set in B2G. 

This is one of the issues causing several mochitests to fail

content/base/test/fileutils.js
content/base/test/test_websocket.html
content/base/test/websocket_hybi/test_send-blob.html
content/base/test/test_bug403852.html
content/base/test/test_XHRSendData.html
content/base/test/test_fileapi.html
content/html/content/test/forms/test_min_attribute.html
content/html/content/test/forms/test_required_attribute.html
content/html/content/test/forms/test_max_attribute.html
content/html/content/test/forms/test_step_attribute.html
content/html/content/test/test_bug590353-2.html
content/html/content/test/test_bug523771.html
content/html/content/test/test_bug598643.html
dom/apps/tests/test_signed_pkg_launch.html
dom/file/test/test_archivereader_zip_in_zip.html
dom/file/test/test_archivereader_nonUnicode.html
dom/file/test/test_archivereader.html
dom/file/test/test_archivereader.html
security/manager/ssl/tests/mochitest/mixedcontent/test_bug383369.html

Comment 1

[[e-mail] [:onecyrenus]]

Attachment: Directory Service patch

directoryService patch to enable ProfD, basically I am selecting the active profile, and obtaining it's directory. 
I couldn't think of a better mechanism for setting this value.

Comment 2

[Dave Hylands [:dhylands]]

Comment on attachment 770444 [details] [diff] [review]
Directory Service patch

Review of attachment 770444 [details] [diff] [review]:
-----------------------------------------------------------------

Fly-by commit

::: b2g/components/DirectoryProvider.js
@@ +61,5 @@
>        persistent.value = true;
>        return file;
>      }
> +    if (prop == "ProfD") {
> +      let profSvc = Cc["@mozilla.org/toolkit/profile-service;1"].getService(Ci.nsIToolkitProfileServ

This line seems to be missng something at the end?

Comment 3

[Dave Hylands [:dhylands]]

Bah - I meant Fly-by comment

Comment 4

[[e-mail] [:onecyrenus]]

Attachment: Updated patch using hg

Comment 5

[[e-mail] [:onecyrenus]]

Would like to add a comment here that with this patch.  I am able to get the file handle but whenever I attempt an operation like .append("foo") I get an NS_ERROR_FAILURE

3274 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/file/test/test_archivereader_zip_in_zip.html | uncaught exception - NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIProperties.get] at chrome://specialpowers/content/specialpowersAPI.js:87

Comment 6

[[e-mail] [:onecyrenus]]

Attachment: Working patch for ProfD problem

I bypassed this by just hardcoding the value, which is consistent with the rest of the library. 

~3700 more tests in the nightly run.. attached is the hg patch

Comment 7

[[e-mail] [:onecyrenus]]

Running the patch through the try server to verify all tests pass, just hold off on the review until then.

Comment 8

[[e-mail] [:onecyrenus]]

Attachment: Directory Service patch

Comment 9

[[e-mail] [:onecyrenus]]

Comment on attachment 771757 [details] [diff] [review]
Directory Service patch

I am waiting on getting my new rsa key up on hg so i can run through try server.

Comment 10

[[e-mail] [:onecyrenus]]

https://tbpl.mozilla.org/?tree=Try&rev=3effde35b859

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/projects/birch/rev/c881d9e4a406

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Backed out for causing Marionette test timeouts.
https://hg.mozilla.org/projects/birch/rev/bce29c9c7ce3

https://tbpl.mozilla.org/php/getParsedLog.php?id=25084077&tree=Birch

Comment 13

[[e-mail] [:onecyrenus]]

https://tbpl.mozilla.org/?tree=Try&rev=e71b445ff532

Comment 14

[[e-mail] [:onecyrenus]]

Ryan, 
  I think that this needs a closer look, is it possible the marionette test timeouts were due to some transient network issue.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Your Try run isn't running the Marionette tests in question. The failures were in the B2G suite, and they most definitely didn't go away until I backed you out (note the times of the comments - it took me all day to narrow it down to yours).

Comment 16

[[e-mail] [:onecyrenus]]

Ryan, 
  Unsure how to run the marionette tests in question. I thought below command would run all the tests? 

– try: -b o -p all -u all -t none

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://tbpl.mozilla.org/?tree=Try&rev=058ce5a4b81e

Comment 18

[[e-mail] [:onecyrenus]]

https://tbpl.mozilla.org/?tree=Try&rev=56556a2a9831

Comment 19

[[e-mail] [:onecyrenus]]

Attachment: Directory Service patch

Found the problem with marionette tests, and was able to rectify in the patch. 

Basically marionette is expecting a null object to be returned, so now I just check to see if there is a profile directory, and if there is not, return null.

Comment 20

[[e-mail] [:onecyrenus]]

Attachment: Directory Service patch

Comment 21

[[e-mail] [:onecyrenus]]

https://tbpl.mozilla.org/?tree=Try&rev=aaef506a8d35

Comment 22

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/projects/birch/rev/aa90caa3271c

Comment 23

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/aa90caa3271c