Last Comment Bug 889610 - Aero glass fog cut off in customization mode on Windows 7
: Aero glass fog cut off in customization mode on Windows 7
Status: RESOLVED FIXED
[Australis:P?][Australis:M8]
:
Product: Firefox
Classification: Client Software
Component: Theme (show other bugs)
: Trunk
: x86 Windows 7
-- normal (vote)
: Firefox 28
Assigned To: :Gijs (away until Feb 27)
:
: Dão Gottwald [:dao]
Mentors:
Depends on: 886281
Blocks: australis-tabs-win
  Show dependency treegraph
 
Reported: 2013-07-02 14:55 PDT by :Gijs (away until Feb 27)
Modified: 2013-11-18 13:00 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (1002 bytes, patch)
2013-07-02 14:55 PDT, :Gijs (away until Feb 27)
jaws: review+
Details | Diff | Splinter Review

Description User image :Gijs (away until Feb 27) 2013-07-02 14:55:57 PDT
Created attachment 770450 [details] [diff] [review]
Patch

Now that bug 886281 landed, glass fog is cut off in customization mode.
Comment 1 User image Jared Wein [:jaws] (please needinfo? me) 2013-07-02 15:16:28 PDT
Comment on attachment 770450 [details] [diff] [review]
Patch

Review of attachment 770450 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/windows/browser-aero.css
@@ +244,5 @@
>      z-index: -1;
>    }
>  
>    /* Need to constrain the glass fog to avoid overlapping layers, see bug 886281. */
> +  #main-window:not([customizing]) #navigator-toolbox:not(:-moz-lwtheme) {

#main-window:not([customizing]) #navigator-toolbox:not(:-moz-lwtheme),
#main-window:not([customize-exiting]) #navigator-toolbox:not(:-moz-lwtheme) {
  overflow-y: hidden;
}
Comment 2 User image Jared Wein [:jaws] (please needinfo? me) 2013-07-02 15:32:46 PDT
(In reply to Jared Wein [:jaws] from comment #1)
> Comment on attachment 770450 [details] [diff] [review]
> Patch
> 
> Review of attachment 770450 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: browser/themes/windows/browser-aero.css
> @@ +244,5 @@
> >      z-index: -1;
> >    }
> >  
> >    /* Need to constrain the glass fog to avoid overlapping layers, see bug 886281. */
> > +  #main-window:not([customizing]) #navigator-toolbox:not(:-moz-lwtheme) {
> 
> #main-window:not([customizing]) #navigator-toolbox:not(:-moz-lwtheme),
> #main-window:not([customize-exiting]) #navigator-toolbox:not(:-moz-lwtheme) {
>   overflow-y: hidden;
> }

Sorry, this is wrong. It should be:

> #navigator-toolbox:not(:-moz-lwtheme) {
>   overflow-y: hidden;
> }

> #main-window[customizing] #navigator-toolbox:not(:-moz-lwtheme),
> #main-window[customize-exiting] #navigator-toolbox:not(:-moz-lwtheme) {
>   overflow-y: auto;
> }

Which could also be written as:

> #main-window:not([customizing]) #navigator-toolbox:not(:-moz-lwtheme) {
>   overflow-y: hidden;
> }

> #main-window[customize-exiting] #navigator-toolbox:not(:-moz-lwtheme) {
>   overflow-y: auto;
> }
Comment 3 User image Dão Gottwald [:dao] 2013-07-02 15:45:56 PDT
use this:

> #main-window:not([customizing]):not([customize-exiting]) #navigator-toolbox:not(:-moz-lwtheme) {
>   overflow-y: hidden;
> }
Comment 4 User image :Gijs (away until Feb 27) 2013-07-03 02:28:31 PDT
https://hg.mozilla.org/projects/ux/rev/884a90d51042
Comment 5 User image :Gijs (away until Feb 27) 2013-11-18 13:00:03 PST
https://hg.mozilla.org/mozilla-central/rev/884a90d51042

Note You need to log in before you can comment on or make changes to this bug.