Aero glass fog cut off in customization mode on Windows 7

RESOLVED FIXED in Firefox 28

Status

()

Firefox
Theme
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Gijs, Assigned: Gijs)

Tracking

Trunk
Firefox 28
x86
Windows 7
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [Australis:P?][Australis:M8])

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Created attachment 770450 [details] [diff] [review]
Patch

Now that bug 886281 landed, glass fog is cut off in customization mode.
Attachment #770450 - Flags: review?(jaws)
Comment on attachment 770450 [details] [diff] [review]
Patch

Review of attachment 770450 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/windows/browser-aero.css
@@ +244,5 @@
>      z-index: -1;
>    }
>  
>    /* Need to constrain the glass fog to avoid overlapping layers, see bug 886281. */
> +  #main-window:not([customizing]) #navigator-toolbox:not(:-moz-lwtheme) {

#main-window:not([customizing]) #navigator-toolbox:not(:-moz-lwtheme),
#main-window:not([customize-exiting]) #navigator-toolbox:not(:-moz-lwtheme) {
  overflow-y: hidden;
}
Attachment #770450 - Flags: review?(jaws) → review+
(In reply to Jared Wein [:jaws] from comment #1)
> Comment on attachment 770450 [details] [diff] [review]
> Patch
> 
> Review of attachment 770450 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: browser/themes/windows/browser-aero.css
> @@ +244,5 @@
> >      z-index: -1;
> >    }
> >  
> >    /* Need to constrain the glass fog to avoid overlapping layers, see bug 886281. */
> > +  #main-window:not([customizing]) #navigator-toolbox:not(:-moz-lwtheme) {
> 
> #main-window:not([customizing]) #navigator-toolbox:not(:-moz-lwtheme),
> #main-window:not([customize-exiting]) #navigator-toolbox:not(:-moz-lwtheme) {
>   overflow-y: hidden;
> }

Sorry, this is wrong. It should be:

> #navigator-toolbox:not(:-moz-lwtheme) {
>   overflow-y: hidden;
> }

> #main-window[customizing] #navigator-toolbox:not(:-moz-lwtheme),
> #main-window[customize-exiting] #navigator-toolbox:not(:-moz-lwtheme) {
>   overflow-y: auto;
> }

Which could also be written as:

> #main-window:not([customizing]) #navigator-toolbox:not(:-moz-lwtheme) {
>   overflow-y: hidden;
> }

> #main-window[customize-exiting] #navigator-toolbox:not(:-moz-lwtheme) {
>   overflow-y: auto;
> }
use this:

> #main-window:not([customizing]):not([customize-exiting]) #navigator-toolbox:not(:-moz-lwtheme) {
>   overflow-y: hidden;
> }
(Assignee)

Comment 4

4 years ago
https://hg.mozilla.org/projects/ux/rev/884a90d51042
Whiteboard: [Australis:P?] → [Australis:P?][fixed-in-ux]
(Assignee)

Updated

4 years ago
Whiteboard: [Australis:P?][fixed-in-ux] → [Australis:P?][Australis:M8][fixed-in-ux]
(Assignee)

Comment 5

4 years ago
https://hg.mozilla.org/mozilla-central/rev/884a90d51042
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:P?][Australis:M8][fixed-in-ux] → [Australis:P?][Australis:M8]
Target Milestone: --- → Firefox 28
You need to log in before you can comment on or make changes to this bug.