88964 - sortByDocumentOrder has a few minor problems

Status: VERIFIED FIXED

(Core :: XSLT, defect, P2)

Description

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

sortByDocumentOrder suffers the following problems:

* off-by-one error in ProcessorState::sortByDocumentOrder
* attributes has same doc-order as first child
* nodesets containing nodes from multiple documents isn't sorter correctly

patch coming up... tomorrow

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: patch to fix, ver 1

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

this should be mine

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Yac, there's a bug in the patch, the

-                orderInfo->order[0] = 0;
+                orderInfo->order[0] = getChildNumber(node);

should be done a few lines up, in the
|if (node->getNodeType() == Node::DOCUMENT_NODE) {|

can't produce a patch right now though...

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: smallest possible patch to fix the main problem

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: diff -w to show basic idea

Comment 6

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

This should show the idea I have for nodeOrder comparisons. I'd like to give 
some additional love to DOMHelper::getDocumentOrder to make it out-of-memory-on-
new safe, but no functional changes.

I'm also thinking about moving the getDocumentOrder into Node, but that is 
perhaps a different bug.

Comment 7

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

testcases coming tomorrow...

Comment 8

[Peter Van der Beken [:peterv]]

r=peterv for 42984.

Comment 9

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

this was fixed along with bug 94471

Comment 10

[Axel Hecht]

we didn't verify for a long time.
I really checked, so VERIFIED.