889652 - Add support for building with pulseaudio support on gonk

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Michael Wu [:mwu]]

Attachment: Add support for building with pulseaudio support on gonk

This tells configure.in how to find pulseaudio when we're on gonk.

Comment 1

[Michael Wu [:mwu]]

Attachment: Directly access libpulse on Gonk

The library name is different on gonk. We don't need runtime loading of libpulse though, so this disables it on ANDROID. I can also use MOZ_WIDGET_GONK, but ANDROID seems more suitable for a standalone library.

Comment 2

[Michael Wu [:mwu]]

Attachment: Add support for building with pulseaudio support on gonk, v2

Comment 3

[Mike Hommey [:glandium]]

Comment on attachment 777274 [details] [diff] [review]
Add support for building with pulseaudio support on gonk, v2

Review of attachment 777274 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +5811,5 @@
>      AC_DEFINE(MOZ_CUBEB)
> +    if test -z "$gonkdir"; then
> +        PKG_CHECK_MODULES(MOZ_PULSEAUDIO, libpulse, ,
> +             [echo "$MOZ_PULSEAUDIO_PKG_ERRORS"
> +              AC_MSG_ERROR([pulseaudio audio backend requires libpulse package])])

while you're here, please change that to (...) libpulse development package.

Comment 4

[Matthew Gregan [:kinetik]]

Comment on attachment 777270 [details] [diff] [review]
Directly access libpulse on Gonk

Review of attachment 777270 [details] [diff] [review]:
-----------------------------------------------------------------

So that it makes sense in the upstream repository, can you please move the ifdef ANDROID/define DISABLE_LIBPULSE_DLOPEN logic to the Gecko makefiles?

Comment 5

[Michael Wu [:mwu]]

Attachment: Add support for building with pulseaudio support on gonk, v3

Comment 6

[Michael Wu [:mwu]]

Attachment: Directly access libpulse on Gonk, v2

Comment 7

[Arun Raghavan]

Comment on attachment 778293 [details] [diff] [review]
Directly access libpulse on Gonk, v2

The local variable 'libpulse' needs to be explicitly initialised to NULL as well.

Comment 8

[Michael Wu [:mwu]]

(In reply to Arun Raghavan from comment #7)
> Comment on attachment 778293 [details] [diff] [review]
> Directly access libpulse on Gonk, v2
> 
> The local variable 'libpulse' needs to be explicitly initialised to NULL as
> well.

Good catch. I've made the change in the pull request to the upstream repo.

https://github.com/kinetiknz/cubeb/pull/29

Comment 9

[Michael Wu [:mwu]]

https://hg.mozilla.org/projects/birch/rev/8ea7c73c9834
https://hg.mozilla.org/projects/birch/rev/0fab68deb644

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/0fab68deb644