Closed Bug 889652 Opened 7 years ago Closed 7 years ago

Add support for building with pulseaudio support on gonk

Categories

(Firefox Build System :: General, defect)

All
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla25

People

(Reporter: mwu, Assigned: mwu)

References

Details

Attachments

(2 files, 3 obsolete files)

This tells configure.in how to find pulseaudio when we're on gonk.
Attached patch Directly access libpulse on Gonk (obsolete) — Splinter Review
The library name is different on gonk. We don't need runtime loading of libpulse though, so this disables it on ANDROID. I can also use MOZ_WIDGET_GONK, but ANDROID seems more suitable for a standalone library.
Attachment #777270 - Flags: review?(kinetik)
Attachment #770514 - Attachment is obsolete: true
Attachment #777274 - Flags: review?(mh+mozilla)
Comment on attachment 777274 [details] [diff] [review]
Add support for building with pulseaudio support on gonk, v2

Review of attachment 777274 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +5811,5 @@
>      AC_DEFINE(MOZ_CUBEB)
> +    if test -z "$gonkdir"; then
> +        PKG_CHECK_MODULES(MOZ_PULSEAUDIO, libpulse, ,
> +             [echo "$MOZ_PULSEAUDIO_PKG_ERRORS"
> +              AC_MSG_ERROR([pulseaudio audio backend requires libpulse package])])

while you're here, please change that to (...) libpulse development package.
Attachment #777274 - Flags: review?(mh+mozilla) → review+
Comment on attachment 777270 [details] [diff] [review]
Directly access libpulse on Gonk

Review of attachment 777270 [details] [diff] [review]:
-----------------------------------------------------------------

So that it makes sense in the upstream repository, can you please move the ifdef ANDROID/define DISABLE_LIBPULSE_DLOPEN logic to the Gecko makefiles?
Attachment #777270 - Flags: review?(kinetik) → review+
Attachment #777270 - Attachment is obsolete: true
Comment on attachment 778293 [details] [diff] [review]
Directly access libpulse on Gonk, v2

The local variable 'libpulse' needs to be explicitly initialised to NULL as well.
(In reply to Arun Raghavan from comment #7)
> Comment on attachment 778293 [details] [diff] [review]
> Directly access libpulse on Gonk, v2
> 
> The local variable 'libpulse' needs to be explicitly initialised to NULL as
> well.

Good catch. I've made the change in the pull request to the upstream repo.

https://github.com/kinetiknz/cubeb/pull/29
https://hg.mozilla.org/mozilla-central/rev/0fab68deb644
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.