Closed
Bug 889669
Opened 11 years ago
Closed 11 years ago
Mach's pretty incorrect-Python-version error isn't.
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla25
People
(Reporter: ckitching, Assigned: gps)
Details
Attachments
(1 file)
1.29 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
When running Mach with Python3.3, the following cryptic stacktrace appears, despite the attempt made on lines 111-115 of mach_bootstrap.py to prevent such badness. Traceback (most recent call last): File "./mach", line 47, in <module> mach = load_mach(dir_path) File "./mach", line 20, in load_mach import mach_bootstrap File "/home/chris/Fennec/Fennec/build/mach_bootstrap.py", line 130 os.makedirs(state_env_dir, mode=0777) ^ SyntaxError: invalid token
Assignee | ||
Comment 1•11 years ago
|
||
Trivial change. I /could/ honor umask, but I'm lazy.
Attachment #770537 -
Flags: review?(ted)
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → gps
Updated•11 years ago
|
Attachment #770537 -
Flags: review?(ted) → review+
Comment 2•11 years ago
|
||
(In reply to Gregory Szorc [:gps] from comment #1) > Created attachment 770537 [details] [diff] [review] > Use Python 3 compatible octal syntax > > Trivial change. I /could/ honor umask, but I'm lazy. mkdir honors umask for you.
Assignee | ||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e26fd33b8c83
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•