Closed Bug 889669 Opened 7 years ago Closed 7 years ago

Mach's pretty incorrect-Python-version error isn't.

Categories

(Firefox Build System :: General, defect)

x86_64
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla25

People

(Reporter: ckitching, Assigned: gps)

Details

Attachments

(1 file)

When running Mach with Python3.3, the following cryptic stacktrace appears, despite the attempt made on lines 111-115 of mach_bootstrap.py to prevent such badness.

Traceback (most recent call last):
  File "./mach", line 47, in <module>
    mach = load_mach(dir_path)
  File "./mach", line 20, in load_mach
    import mach_bootstrap
  File "/home/chris/Fennec/Fennec/build/mach_bootstrap.py", line 130
    os.makedirs(state_env_dir, mode=0777)
                                       ^
SyntaxError: invalid token
Trivial change. I /could/ honor umask, but I'm lazy.
Attachment #770537 - Flags: review?(ted)
Assignee: nobody → gps
Attachment #770537 - Flags: review?(ted) → review+
(In reply to Gregory Szorc [:gps] from comment #1)
> Created attachment 770537 [details] [diff] [review]
> Use Python 3 compatible octal syntax
> 
> Trivial change. I /could/ honor umask, but I'm lazy.

mkdir honors umask for you.
https://hg.mozilla.org/mozilla-central/rev/e26fd33b8c83
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.