889678 - TypeError in python/mozbuild/mozpack/test/test_manifests.py

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Nick Alexander :nalexander [he/him]]

I stumbled across the following test error while landing Bug 818744.  This was after adding a missing

if __name__ == '__main__':
    mozunit.main()

to the file.  This (failing?) test was added by Bug 884587.

 0:01.09 TEST-UNEXPECTED-FAIL | ./python/mozbuild/mozpack/test/test_manifests.py | line 47, test_unknown_version: not all arguments converted during string formatting
 0:01.10 ERROR: test_unknown_version (__main__.TestPurgeManifest)
 0:01.10 Traceback (most recent call last):
 0:01.10 File "./python/mozbuild/mozpack/test/test_manifests.py", line 47, in test_unknown_version
 0:01.10 PurgeManifest.from_path(p)
 0:01.10 File "/Users/ncalexan/Mozilla/mcgit/python/mozbuild/mozpack/manifests.py", line 42, in from_path
 0:01.10 return PurgeManifest.from_fileobj(fh)
 0:01.10 File "/Users/ncalexan/Mozilla/mcgit/python/mozbuild/mozpack/manifests.py", line 51, in from_fileobj
 0:01.10 version)
 0:01.10 TypeError: not all arguments converted during string formatting
 0:01.10

Comment 1

[Gregory Szorc [:gps]]

Oh, that test file is missing a __main__ section and thus isn't getting executed. Da derp de derp.

Comment 2

[Gregory Szorc [:gps]]

Attachment: Fix mozpack purge manifest tests and bug in version detection code

Fortunately the tests were passing and the failing code won't be hit
until we deploy a new version of the purge manifest files.

Good find, Nick.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/717cdae289f8