If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

TEST-UNEXPECTED-FAIL | tests/test-places-bookmarks.testCaching | lookup occurs once for each item and parent - 6 == 5

RESOLVED FIXED in Firefox 25

Status

Add-on SDK
General
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: KWierso, Assigned: jsantell)

Tracking

({intermittent-failure})

unspecified
mozilla25
intermittent-failure

Firefox Tracking Flags

(firefox24 unaffected, firefox25 fixed)

Details

(URL)

(Reporter)

Description

4 years ago
TEST-UNEXPECTED-FAIL | tests/test-places-bookmarks.testCaching | lookup occurs once for each item and parent - 6 == 5
TEST-INFO | Traceback (most recent call last):
  File "resource://extensions.modules.5f4dc62b-d1a5-46a4-b37d-b6fc7c8e9f05-at-jetpack.commonjs.path/sdk/timers.js", line 31, in notify
    callback.apply(null, args);
  File "resource://extensions.modules.5f4dc62b-d1a5-46a4-b37d-b6fc7c8e9f05-at-jetpack.commonjs.path.tests/test-places-bookmarks.js", line 837, in exports.testCaching/</<
    assert.equal(count, 6, 'lookup occurs once for each item and parent');
  File "resource://extensions.modules.5f4dc62b-d1a5-46a4-b37d-b6fc7c8e9f05-at-jetpack.commonjs.path/sdk/test/assert.js", line 125, in equal
    operator: "=="
  File "resource://extensions.modules.5f4dc62b-d1a5-46a4-b37d-b6fc7c8e9f05-at-jetpack.commonjs.path/sdk/test/assert.js", line 89, in fail
    this._log.fail(message);
  File "resource://extensions.modules.5f4dc62b-d1a5-46a4-b37d-b6fc7c8e9f05-at-jetpack.commonjs.path/sdk/deprecated/unit-test.js", line 84, in fail
    this.console.testMessage(false, false, this.test.name, message);
  File "resource://extensions.modules.5f4dc62b-d1a5-46a4-b37d-b6fc7c8e9f05-at-jetpack.commonjs.path/sdk/test/harness.js", line 523, in testMessage
    this.trace();

This test has failed every run in the push that landed Places.

Comment 1

4 years ago
Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/56c772c0e50e698cb8cb189688e2bcd7570f3de9
Bug 889698 force async Places API methods and host messaging

https://github.com/mozilla/addon-sdk/commit/bb25ded6e61fd180f7090fab6137c4ed73da190b
Merge pull request #1076 from jsantell/places-api

Bug 889698 force async Places API methods and host messaging
(Reporter)

Comment 2

4 years ago
Looks fixed to me!
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED

Comment 3

4 years ago
Commits pushed to firefox25 at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/56c772c0e50e698cb8cb189688e2bcd7570f3de9
Bug 889698 force async Places API methods and host messaging

https://github.com/mozilla/addon-sdk/commit/bb25ded6e61fd180f7090fab6137c4ed73da190b
Merge pull request #1076 from jsantell/places-api
status-firefox24: --- → affected
status-firefox25: --- → fixed
Target Milestone: --- → mozilla25
status-firefox24: affected → unaffected
You need to log in before you can comment on or make changes to this bug.