Open Bug 889710 Opened 11 years ago Updated 2 years ago

Consider to add AllowRepeat flag for rendering Async video for devices which allow non-power-of-two textures

Categories

(Core :: Graphics: Layers, defect)

x86_64
Linux
defect

Tracking

()

People

(Reporter: romaxa, Unassigned)

Details

Attachments

(1 file)

Currently we seems always setup TextureInfo() which makes AllowRepeat flag not enabled even for devices which allow non-power-of-two textures

So we always wasting CPU time on GLContext::DecomposeIntoNoRepeatTriangles

May be we should double check that
Attached patch Possible fixSplinter Review
Attachment #770620 - Flags: feedback?(ncameron)
Comment on attachment 770620 [details] [diff] [review]
Possible fix

Review of attachment 770620 [details] [diff] [review]:
-----------------------------------------------------------------

Is this all it takes to get going? Doesn't look like we use that flag anywhere. Should we not check whether it is OK to allow repeating before we add the flag? And I don't know about the GLContext change, you should check with jgilbert.
Attachment #770620 - Flags: feedback?(ncameron)
we do enable Allow Repeat by default, and then we do select  required  wrap mode depend on GLContext capabilities.
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: