Consider to add AllowRepeat flag for rendering Async video for devices which allow non-power-of-two textures

NEW
Unassigned

Status

()

Core
Graphics: Layers
5 years ago
5 years ago

People

(Reporter: romaxa, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Currently we seems always setup TextureInfo() which makes AllowRepeat flag not enabled even for devices which allow non-power-of-two textures

So we always wasting CPU time on GLContext::DecomposeIntoNoRepeatTriangles

May be we should double check that
(Reporter)

Comment 1

5 years ago
Created attachment 770620 [details] [diff] [review]
Possible fix
(Reporter)

Updated

5 years ago
Attachment #770620 - Flags: feedback?(ncameron)

Comment 2

5 years ago
Comment on attachment 770620 [details] [diff] [review]
Possible fix

Review of attachment 770620 [details] [diff] [review]:
-----------------------------------------------------------------

Is this all it takes to get going? Doesn't look like we use that flag anywhere. Should we not check whether it is OK to allow repeating before we add the flag? And I don't know about the GLContext change, you should check with jgilbert.
Attachment #770620 - Flags: feedback?(ncameron)
(Reporter)

Comment 3

5 years ago
we do enable Allow Repeat by default, and then we do select  required  wrap mode depend on GLContext capabilities.
You need to log in before you can comment on or make changes to this bug.