Closed Bug 889711 Opened 11 years ago Closed 11 years ago

recently closed tab not in history, not restored with Ctrl+Shift+T

Categories

(Firefox :: Session Restore, defect)

Product:
Firefox
Component:
Session Restore
Version:
25 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 25
Tracking Flags:
Tracking Status
firefox24 --- unaffected
firefox25 + verified

People

(Reporter: landis, Assigned: ttaubert)

References

Details

(Keywords: regression) 

User Agent: Mozilla/5.0 (X11; Linux i686; rv:25.0) Gecko/20130702 Firefox/25.0 (Nightly/Aurora)
Build ID: 20130702110300

Steps to reproduce:

close tab via 'x' on tab


Actual results:

using Ctrl+Shift+T does not restore recent tab.

also:
'Nightly button'  > History or History menu> Recently Closed Tabs > * Recent or Last Closed Tab is Not listed 

*note: Older tabs, before today's update (02.07.13, 2013.07.02).



Expected results:

Ctrl+Shift+T should restore last closed tab and subsequent C+Sh+T's presses should restore progressively older 'Closed Tabs'.

'Recently Closed Tabs' should be listed at or near top of History > 'Recently Closed Tabs' list.
Component: Untriaged → Tabbed Browser
Mozilla/5.0 (Windows NT 6.1; rv:25.0) Gecko/20130702 Firefox/25.0

This bug is weird. It happens intermittently. I don't know how to reliably reproduce this though...
Keywords: qawanted, regressionwindow-wanted
OS: Linux → All
Seems to always happen if you have a tab pinned when starting up Firefox.

Steps:
Pin a tab
Close Firefox
Start Firefox again
Open a new tab
Close the tab
Forgot to add:
Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:25.0) Gecko/20130704 Firefox/25.0
I saw this happening as well in an Australis build from yesterday.
Status: UNCONFIRMED → NEW
Ever confirmed: true
I can also reproduce the problem with STR of comment#2

Regression window(m-c)
Good:
http://hg.mozilla.org/mozilla-central/rev/614e1793e958
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:25.0) Gecko/20130629 Firefox/25.0 ID:20130629173041
Bad:
http://hg.mozilla.org/mozilla-central/rev/e24391ffbe7e
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:25.0) Gecko/20130630 Firefox/25.0 ID:20130630083743
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=614e1793e958&tochange=e24391ffbe7e

Regression window(m-i)
Good:
http://hg.mozilla.org/integration/mozilla-inbound/rev/3f5669a7cd14
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:25.0) Gecko/20130630 Firefox/25.0 ID:20130630080142
Bad:
http://hg.mozilla.org/integration/mozilla-inbound/rev/fe2f77d51bf1
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:25.0) Gecko/20130630 Firefox/25.0 ID:20130630084042
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=3f5669a7cd14&tochange=fe2f77d51bf1

Regression window(fx-team)
Good:
http://hg.mozilla.org/integration/fx-team/rev/52f605debfd4
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:25.0) Gecko/20130627 Firefox/25.0 ID:20130627033223
Bad:
http://hg.mozilla.org/integration/fx-team/rev/086465524970
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:25.0) Gecko/20130627 Firefox/25.0 ID:20130627073223
Pushlog:
http://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=52f605debfd4&tochange=086465524970

Regressed by:
086465524970	Tim Taubert — Bug 887394 - Don't collect state right after startup when restoring the initial session; r=yoric
Blocks: 887394
status-firefox25: --- → affected
tracking-firefox25: --- → ?
Keywords: regressionwindow-wanted → regression
I can also confirm and want to add that 'unpinning' the pinned tab does not restore the 'recently close tab list' until you close/restart the browser.
Component: Tabbed Browser → Session Restore
Depends on: 891360
Component: Session Restore → Tabbed Browser
It's definitely a sessionstore bug.
Component: Tabbed Browser → Session Restore
Dropping qawanted keyword as per comment 5.
Keywords: qawanted
Assignee: nobody → ttaubert
status-firefox24: --- → unaffected
tracking-firefox25: ? → +
Fixed in today's Nightly.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Hardware: x86 → All
status-firefox25: affected → fixed
Target Milestone: --- → Firefox 25
Landis, can you please check that this is resolved for you in tomorrow's Firefox Nightly?
Flags: needinfo?(landis)
WORKSFORME now where it didn't before, even with pinned tabs.
(In reply to Alex Xu from comment #11)
> WORKSFORME now where it didn't before, even with pinned tabs.

That's good enough for me. Thanks Alex.
Status: RESOLVED → VERIFIED
status-firefox25: fixed → verified
Flags: needinfo?(landis)
You need to log in before you can comment on or make changes to this bug.