Clean up indexedDB ipdl files

RESOLVED FIXED in mozilla26

Status

()

Core
DOM: IndexedDB
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: dzbarsky, Assigned: dzbarsky)

Tracking

unspecified
mozilla26
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

25.32 KB, patch
Ben Turner (not reading bugmail, use the needinfo flag!)
: review+
Details | Diff | Splinter Review
Comment hidden (empty)
(Assignee)

Updated

5 years ago
Assignee: nobody → dzbarsky
(Assignee)

Updated

4 years ago
Summary: Investigate whether FIXME_Bug_521898_objectstore is still needed → Clean up indexedDB ipdl files
(Assignee)

Comment 1

4 years ago
Created attachment 771669 [details] [diff] [review]
Patch
Attachment #771669 - Flags: review?(bent.mozilla)
Comment on attachment 771669 [details] [diff] [review]
Patch

Review of attachment 771669 [details] [diff] [review]:
-----------------------------------------------------------------

Nice! Thanks.

::: dom/indexedDB/IDBKeyRange.cpp
@@ +416,5 @@
>  
>  // Explicitly instantiate for all our key range types... Grumble.
>  template already_AddRefed<IDBKeyRange>
> +IDBKeyRange::FromSerializedKeyRange<KeyRange>
> +(const KeyRange& aKeyRange);

Nit: This (and another below) should fit on one line now.

::: dom/indexedDB/ipc/IndexedDBParent.cpp
@@ +1544,1 @@
>      aParams.optionalKeyRange();

Nit: This should fit on one line now, a bunch of other places in this file too.

::: dom/indexedDB/ipc/PIndexedDBRequest.ipdl
@@ +62,1 @@
>  };

Nit: I'd prefer (here and below):

  struct DeleteResponse
  { };

  struct ClearResponse
  { };
Attachment #771669 - Flags: review?(bent.mozilla) → review+
(Assignee)

Comment 3

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/ea40469474a9
https://hg.mozilla.org/mozilla-central/rev/ea40469474a9
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.