Closed Bug 889734 Opened 6 years ago Closed 6 years ago

Clean up indexedDB ipdl files

Categories

(Core :: DOM: IndexedDB, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: dzbarsky, Assigned: dzbarsky)

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → dzbarsky
Summary: Investigate whether FIXME_Bug_521898_objectstore is still needed → Clean up indexedDB ipdl files
Attached patch PatchSplinter Review
Attachment #771669 - Flags: review?(bent.mozilla)
Comment on attachment 771669 [details] [diff] [review]
Patch

Review of attachment 771669 [details] [diff] [review]:
-----------------------------------------------------------------

Nice! Thanks.

::: dom/indexedDB/IDBKeyRange.cpp
@@ +416,5 @@
>  
>  // Explicitly instantiate for all our key range types... Grumble.
>  template already_AddRefed<IDBKeyRange>
> +IDBKeyRange::FromSerializedKeyRange<KeyRange>
> +(const KeyRange& aKeyRange);

Nit: This (and another below) should fit on one line now.

::: dom/indexedDB/ipc/IndexedDBParent.cpp
@@ +1544,1 @@
>      aParams.optionalKeyRange();

Nit: This should fit on one line now, a bunch of other places in this file too.

::: dom/indexedDB/ipc/PIndexedDBRequest.ipdl
@@ +62,1 @@
>  };

Nit: I'd prefer (here and below):

  struct DeleteResponse
  { };

  struct ClearResponse
  { };
Attachment #771669 - Flags: review?(bent.mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/ea40469474a9
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.