Design and implement a ContactsMatcher module (passive mode)

RESOLVED FIXED in 1.1 QE4 (15jul)

Status

Firefox OS
Gaia::Contacts
P2
normal
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: Jose Manuel Cantera, Assigned: Jose Manuel Cantera)

Tracking

unspecified
1.1 QE4 (15jul)
x86
Mac OS X
Dependency tree / graph

Firefox Tracking Flags

(blocking-b2g:koi+)

Details

(Whiteboard: [u=commsapps-user c=contacts p=4])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Given a new Contact C the ContactsMatcher module will be responsible for finding another Contact C2 that will be a candidate to be merged or linked with C.
(Assignee)

Updated

5 years ago
Blocks: 875793
(Assignee)

Updated

5 years ago
blocking-b2g: --- → koi?
Whiteboard: [u=commsapps-user c=contacts p=0]
(Assignee)

Updated

4 years ago
Whiteboard: [u=commsapps-user c=contacts p=0] → [u=commsapps-user c=contacts p=4]

Updated

4 years ago
Whiteboard: [u=commsapps-user c=contacts p=4] → [u=commsapps-user c=contact p=4]

Updated

4 years ago
Whiteboard: [u=commsapps-user c=contact p=4] → [u=commsapps-user c=contacts p=4]
listed as must have in v1.2 for COMM team. koi+
blocking-b2g: koi? → koi+
(Assignee)

Comment 2

4 years ago
Created attachment 775582 [details]
Pointer to GH PR

First version. implements silent mode matcher with tests
Attachment #775582 - Flags: review?(francisco.jordano)
Attachment #775582 - Flags: review?(crdlc)
Status: NEW → ASSIGNED
Comment on attachment 775582 [details]
Pointer to GH PR

Great work!! In general, for me, it is ok! Although there are some comments on Gitbub related to refactor most of them. Take a look when you want because I've just finished. Thanks Jose
Attachment #775582 - Flags: review?(crdlc) → review+
Comment on attachment 775582 [details]
Pointer to GH PR

Amazing job!

r+ with Cristian's comments and some of the comments I let you in github. Also could we add a bit of documentation for the methods in general?

Thanks again!
Attachment #775582 - Flags: review?(francisco.jordano) → review+
(Assignee)

Comment 5

4 years ago
https://github.com/mozilla-b2g/gaia/commit/f2e2403873bcd83b046ff2b9baf61e8db6224496
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
(Assignee)

Updated

4 years ago
Summary: Design and implement a ContactsMatcher module → Design and implement a ContactsMatcher module for the passive mode
(Assignee)

Updated

4 years ago
Summary: Design and implement a ContactsMatcher module for the passive mode → Design and implement a ContactsMatcher module (passive mode)

Updated

4 years ago
Blocks: 895799
No longer blocks: 875793
(Assignee)

Updated

4 years ago
Depends on: 897864
(Assignee)

Updated

4 years ago
Depends on: 898345
You need to log in before you can comment on or make changes to this bug.