Closed
Bug 889756
Opened 11 years ago
Closed 11 years ago
Design and implement a ContactsMatcher module (passive mode)
Categories
(Firefox OS Graveyard :: Gaia::Contacts, defect, P2)
Tracking
(blocking-b2g:koi+)
People
(Reporter: jmcf, Assigned: jmcf)
References
Details
(Whiteboard: [u=commsapps-user c=contacts p=4])
Attachments
(1 file)
Given a new Contact C the ContactsMatcher module will be responsible for finding another Contact C2 that will be a candidate to be merged or linked with C.
|
Assignee | |
Updated•11 years ago
|
blocking-b2g: --- → koi?
|
||
Updated•11 years ago
|
Whiteboard: [u=commsapps-user c=contacts p=0]
|
|
Assignee | |
Updated•11 years ago
|
Whiteboard: [u=commsapps-user c=contacts p=0] → [u=commsapps-user c=contacts p=4]
|
||
Updated•11 years ago
|
Whiteboard: [u=commsapps-user c=contacts p=4] → [u=commsapps-user c=contact p=4]
|
|
||
Updated•11 years ago
|
Whiteboard: [u=commsapps-user c=contact p=4] → [u=commsapps-user c=contacts p=4]
|
|
Assignee | |
Comment 2•11 years ago
|
||
First version. implements silent mode matcher with tests
Attachment #775582 -
Flags: review?(francisco.jordano)
Attachment #775582 -
Flags: review?(crdlc)
|
||
Updated•11 years ago
|
Status: NEW → ASSIGNED
|
|
||
Comment 3•11 years ago
|
||
Comment on attachment 775582 [details]
Pointer to GH PR
Great work!! In general, for me, it is ok! Although there are some comments on Gitbub related to refactor most of them. Take a look when you want because I've just finished. Thanks Jose
Attachment #775582 -
Flags: review?(crdlc) → review+
|
||
Comment 4•11 years ago
|
||
Comment on attachment 775582 [details]
Pointer to GH PR
Amazing job!
r+ with Cristian's comments and some of the comments I let you in github. Also could we add a bit of documentation for the methods in general?
Thanks again!
Attachment #775582 -
Flags: review?(francisco.jordano) → review+
|
|
Assignee | |
Comment 5•11 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/f2e2403873bcd83b046ff2b9baf61e8db6224496
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•11 years ago
|
Summary: Design and implement a ContactsMatcher module → Design and implement a ContactsMatcher module for the passive mode
|
|
Assignee | |
Updated•11 years ago
|
Summary: Design and implement a ContactsMatcher module for the passive mode → Design and implement a ContactsMatcher module (passive mode)
|
|
||
Updated•11 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•