889767 - [MMS] AMR audio attachement is recognized and shown as video file

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::SMS, defect, P1)

Description

[Leo]

1. Title: AMR audio attachement is recognized and shown as video file
2. Precondition: Store some files in  SDCard
3. Tester's Action: 1) Start composing mms message and attach an amr music file
4. Detailed Symptom (ENG.) : AMR music file is shown as video in mms and the device crashes when we try to open the file
5. Expected: AMR file should be recognized and shown as audio in the MMS 
6. Reproducibility: Y
1) Frequency Rate : 100%
7. Gaia Master/v1-train: Reproduced on v1-train
8. Gaia Revision: f2d6ed54a236e6e3b94f0abad9f0dacb8a1cc7b3
9. Personal email id: [e-mail]

Comment 1

[Leo]

Attachment: Attached amr file

Comment 2

[Julien Wajsberg [:julienw]]

I don't know why this STR should be leo+.

Is the real STR about receiving a AMR file from another device ?

The problem here is that this filetype is recognised as a video type.

Comment 3

[Julien Wajsberg [:julienw]]

Kaze will investigate why this crashes.

Comment 4

[Wayne Chang [:wchang]]

HI KAZE: you can check if the crashing is related to https://bugzilla.mozilla.org/show_bug.cgi?id=877482

if so, the bug here should be "recognizing audio files as video"

Comment 5

[Wayne Chang [:wchang]]

steve, can you check why the audio file is recognized as video?

Comment 6

[Steve Chung [:steveck]]

CC dominic/SC if more information is required.
After some investigation and discussion, the type of the blob is video/3gp. minetype return from gecko only considered the extension at first. Music/video player have their own metadata parser to handle this situation, so this file could be scanned as audio file.

Instead of have a metadata parser for message app, maybe we can check the blob returning activity(not sure it's accessible or not), or check the video tag width(setting an audio to a video tag will generate a video tag with width=0), but the solutions here will need some gaia changes...

But the most important thing here is we should not crash while opening the file. Even I change to extension to audio type, it still crash. I will attach the log later. If we could open the file correctly with both video/music player, maybe there is not so necessary to classify the file as audio type?

Comment 7

[Steve Chung [:steveck]]

Attachment: Error while opening the file as audio file

Comment 8

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

The PBlobStreamChild assert should be fixed at bug 887093, which is uplifted on 6/30. Maybe you can try with the latest gecko.

Comment 9

[Wayne Chang [:wchang]]

The crashing has bee fix with bug 887093.

The file recognition part here I don't believe is a blocker here given:
1. The file used to test has the wrong mime type as video/3gp per comment 6
2. There is no user impact as the file can still be attached, played - although  playing is via video player the impact is minimal.
3. Pure audio .3gp files are not very commonly used by real users, especially with the wrong mime type.

Leo-'ing here, please renom and give support information if you think required.

Clearing ni on Kaze as crash is fixed.

Comment 10

[Julien Wajsberg [:julienw]]

should we resolve this bug as invalid ?

Steve, wh

Comment 11

[Julien Wajsberg [:julienw]]

should we resolve this bug as invalid ?

Steve, what do you think ?

Comment 12

[Steve Chung [:steveck]]

Just discuss with Wayne and we agree that it could be closed as invalid(and he will handle it), thanks!