889771 - [system] SIM PIN input: width of input box wider than screen

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Unagi with Gaia 1.1.0.0-prerelease 20130702230206

The screen asking for the SIM PIN has now an input box which is wider than the available screen width. The regression started last week or early this one.

Comment 1

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Attachment: Pull Request #10801 - Fix width of SIM PIN input field

CSS fix of the SIM PIN input field width.

Comment 2

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Since v1.1 affected (issue reproducible on latest v1-train: 7a47eef), requesting blocking-b2g:leo

Comment 3

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Attachment: Screenshot before patch

As Fabien requested on IRC, I am posting screenshots of before and after, this being the SIM PIN dialog for latest master (bf98e03).

Comment 4

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Attachment: Screenshot after patch

And this is the screenshot of the SIM PIN dialog after applying the patch.

Comment 5

[Fabien Cazenave [:kaze]]

Comment on attachment 771364 [details]
Pull Request #10801 - Fix width of SIM PIN input field

Thanks Mihai!

Comment 6

[Mihai Cirlanaru [:mihai][:mcirlanaru]]

Thanks for the review, Fabien! Landed on master:
https://github.com/mozilla-b2g/gaia/commit/e40438b9274e98581ccae3c8fa81a05571d97cb4

Comment 7

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted e40438b9274e98581ccae3c8fa81a05571d97cb4 to:
v1-train: 467d92b01af70816d3338fb501f8a6471a743ea8

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Verified fixed with Gaia 1.1.0.0-prerelease 20130713070207 on Unagi.

Comment 10

[sbogati]

Issue no longer repros. in the Leo
Build ID: 20130717070237
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/582e3a70
Gaia: c506c50adaaebcf729ac3c27887ba2931ab79040
Platform Version: 18.1
IM PIN input: width of input box in no loner show wider than screen

Comment 11

[John Ford [:jhford] CET/CEST Berlin Time]

v1.1.0hd: 467d92b01af70816d3338fb501f8a6471a743ea8