889776 - Signup form on firefox/partners does not show on Firefox OS

Status: RESOLVED FIXED

(www.mozilla.org :: Pages & Content, defect)

Description

[Alex Gibson [:agibson]]

On a Firefox OS device, if you click the button that says 'Partner with us', the modal signup form does not appear. 

This appears to be a CSS positioning bug.

(Tested on a Geeksphone Peak device)

Comment 1

[Alex Gibson [:agibson]]

PR here: https://github.com/mozilla/bedrock/pull/1028

Comment 2

[Steven Garrity [:sgarrity]]

I can't replicate this issue on the Geeksphone Peak.

Comment 3

[Alex Gibson [:agibson]]

Strange, definitely appears broken for my on my Geeksphone Peak (OS version: 1.0.1.0-prerelease, build identifier: 20130613185731)

Comment 4

[Jonathan Petto [:jpetto]]

I can replicate the bug, but I believe it to be a phone issue rather than a coding issue.

On both /firefox/partners/ and /firefox/os/, I can replicate the bug if I do a lazy touch - not quite a touch and hold, but longer than a quick tap. If I tap quite quickly, the modal appears.

The behavior above is *almost* consistent, which is why I believe it to be a phone issue.

FWIW, I've noticed laggy/odd click/touch behavior on the Geeksphone in general.

Comment 5

[Alex Gibson [:agibson]]

Sorry, I should have explained the unexpected behaviour a bit more clearly. The bug I'm seeing is not related to miss-tapping (i believe). You can see the modal do *something* so the click is registering, but it's positioning is off in such a way so that you cannot see form content.

Comment 6

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/48d243558fdfeccfc5379635ac5ea76559059bcf
Partners page modal form not showing on Firefox OS devices bug 889776

https://github.com/mozilla/bedrock/commit/b9241bc9002e240da056e37bd65a05f7e7d9437d
Merge pull request #1028 from alexgibson/partners-modal-form-firefox-os-bug-889776

Partners page modal form not showing on Firefox OS devices bug 889776

Comment 7

[raymond [:retornam] (inactive)]

fixed on dev


✗ curl -I https://www-dev.allizom.org/en-US/about/partnerships/foo/
HTTP/1.1 404 Not Found
Server: Apache
X-Backend-Server: bedrock1.dev.webapp.phx1.mozilla.com
Vary: Accept-Encoding
Cache-Control: no-store, no-cache, must-revalidate, post-check=0, pre-check=0, private, max-age=900
Content-Type: text/html; charset=UTF-8
Date: Mon, 15 Jul 2013 19:16:15 GMT
Status: 404 Not Found
Expires: Mon, 15 Jul 2013 19:31:15 GMT
Pragma: no-cache
Transfer-Encoding: chunked
Connection: Keep-Alive
X-Robots-Tag: noodp

✗ curl -I https://www-dev.allizom.org/en-US/about/foo/
HTTP/1.1 404 Not Found
Server: Apache
X-Backend-Server: bedrock1.dev.webapp.phx1.mozilla.com
Vary: Accept-Encoding
Cache-Control: no-store, no-cache, must-revalidate, post-check=0, pre-check=0, private
Content-Type: text/html; charset=UTF-8
Date: Mon, 15 Jul 2013 19:16:27 GMT
Status: 404 Not Found
Pragma: no-cache
Transfer-Encoding: chunked
Connection: Keep-Alive
X-Robots-Tag: noodp

Comment 8

[raymond [:retornam] (inactive)]

sorry ignore the comment above. It was meant for another bug

Comment 9

[raymond [:retornam] (inactive)]

Alex, on a FirefoxOS device, a user cannot check the privacy policy checkbox easily

Comment 10

[Alex Gibson [:agibson]]

There doesn't seem to be a privacy policy checkbox on this form, do you mean another page?

If it's on a newsletter sign up they just use standard form checkboxes. I've noticed Firefox OS devices seem to be a bit hit and miss registering taps sometimes.

Comment 11

[raymond [:retornam] (inactive)]

(In reply to Alex Gibson [:agibson] from comment #10)
> There doesn't seem to be a privacy policy checkbox on this form, do you mean
> another page?
> 
> If it's on a newsletter sign up they just use standard form checkboxes. I've
> noticed Firefox OS devices seem to be a bit hit and miss registering taps
> sometimes.

Alex yeah, on the newsletter sign up. I tried after several refreshes and it was hard to sign-up.

Comment 12

[Alex Gibson [:agibson]]

Well, I guess that's another issue than this bug maybe? I seem to find checkboxes a bit difficult in general on the current version of Firefox OS. Other mobile devices seem ok at this, so I'm not sure if it's something that should be a device issue or a site issue.

Comment 13

[raymond [:retornam] (inactive)]

(In reply to Alex Gibson [:agibson] from comment #12)
> Well, I guess that's another issue than this bug maybe? I seem to find
> checkboxes a bit difficult in general on the current version of Firefox OS.
> Other mobile devices seem ok at this, so I'm not sure if it's something that
> should be a device issue or a site issue.

I'll mark this as resolved since the sign-up form shows up now. I'll file a bug on the Firefox OS product (Browser) component about the checkbox.