Closed
Bug 889778
Opened 9 years ago
Closed 8 years ago
nsDOMCamaraManager: Move NS_WRAPPERCACHE_INTERFACE_MAP_ENTRY to the begin of QI
Categories
(Core :: DOM: Device Interfaces, defect)
Tracking
()
RESOLVED
FIXED
mozilla34
People
(Reporter: allstars.chh, Assigned: mikeh)
References
Details
Attachments
(1 file, 1 obsolete file)
1.64 KB,
patch
|
jst
:
review+
|
Details | Diff | Splinter Review |
See https://bugzilla.mozilla.org/show_bug.cgi?id=883741#c9 and https://bugzilla.mozilla.org/show_bug.cgi?id=883741#c12 I did a test by changing nsRefPtr<nsDOMCameraManager> mCameraManager; to nsCOMPtr<nsDOMCameraManager> mCameraManager; in Navigator.h And I did see ###!!! ASSERTION: QueryInterface needed: 'query_result.get() == mRawPtr', file ../../dist/include/nsCOMPtr.h, line 547 So we should move NS_WRAPPERCACHE_INTERFACE_MAP_ENTRY to the begin of QI.
Reporter | ||
Updated•9 years ago
|
Assignee: nobody → allstars.chh
Reporter | ||
Comment 1•9 years ago
|
||
It seems the assertion is already there without my test patch.
Assignee | ||
Comment 3•8 years ago
|
||
Attachment #8477432 -
Flags: review?(jst)
Assignee | ||
Updated•8 years ago
|
Assignee | ||
Comment 4•8 years ago
|
||
[Blocking Requested - why for this release]: without this patch, the CameraManager is not able to function as a weak nsIObserver: calls to AddObserver(..., true /* weak */) will always fail.
Status: NEW → ASSIGNED
blocking-b2g: --- → 2.1?
Assignee | ||
Updated•8 years ago
|
OS: Linux → Gonk (Firefox OS)
Hardware: x86_64 → ARM
Assignee | ||
Updated•8 years ago
|
Blocks: camera-backlog
Assignee | ||
Comment 5•8 years ago
|
||
Bonus version that moves NS_WRAPPERCACHE... and does proper error-checking. try-server push: https://tbpl.mozilla.org/?tree=Try&rev=33bf9d76141c
Attachment #8477432 -
Attachment is obsolete: true
Attachment #8477432 -
Flags: review?(jst)
Attachment #8477494 -
Flags: review?(jst)
Updated•8 years ago
|
Attachment #8477494 -
Flags: review?(jst) → review+
Assignee | ||
Comment 6•8 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/408786bfc72a
Comment 7•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/408786bfc72a
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Updated•8 years ago
|
blocking-b2g: 2.1? → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•