Closed Bug 889778 Opened 8 years ago Closed 7 years ago
DOMCamara Manager: Move NS _WRAPPERCACHE _INTERFACE _MAP _ENTRY to the begin of QI
See https://bugzilla.mozilla.org/show_bug.cgi?id=883741#c9 and https://bugzilla.mozilla.org/show_bug.cgi?id=883741#c12 I did a test by changing nsRefPtr<nsDOMCameraManager> mCameraManager; to nsCOMPtr<nsDOMCameraManager> mCameraManager; in Navigator.h And I did see ###!!! ASSERTION: QueryInterface needed: 'query_result.get() == mRawPtr', file ../../dist/include/nsCOMPtr.h, line 547 So we should move NS_WRAPPERCACHE_INTERFACE_MAP_ENTRY to the begin of QI.
8 years ago
Assignee: nobody → allstars.chh
It seems the assertion is already there without my test patch.
Assignee: allstars.chh → mhabicher
[Blocking Requested - why for this release]: without this patch, the CameraManager is not able to function as a weak nsIObserver: calls to AddObserver(..., true /* weak */) will always fail.
Status: NEW → ASSIGNED
blocking-b2g: --- → 2.1?
OS: Linux → Gonk (Firefox OS)
Hardware: x86_64 → ARM
Bonus version that moves NS_WRAPPERCACHE... and does proper error-checking. try-server push: https://tbpl.mozilla.org/?tree=Try&rev=33bf9d76141c
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.