Closed Bug 889805 Opened 11 years ago Closed 11 years ago

[MMS] [UX] Thread view. Video uses a wrong size of thumbnail

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect, P1)

Product:
Firefox OS Graveyard
Component:
Gaia::SMS
Platform:
x86
macOS
Type:
defect

Tracking

(blocking-b2g:leo+, b2g18 fixed, b2g-v1.1hd fixed)

Status:
VERIFIED FIXED
Milestone:
1.1 QE4 (15jul)
Project Flags:
blocking-b2g leo+
Tracking Flags:
Tracking Status
b2g18 --- fixed
b2g-v1.1hd --- fixed

People

(Reporter: vicky, Assigned: steveck)

References

Details

(Whiteboard: [u=commsapps-user c=messaging p=0], [LeoVB+] )

Attachments

(2 files)

thumbnail showing idle and part of the hit state of the sprite
44.73 KB, image/png
Details
Link to github
359 bytes, text/html
rexboy
: review+
Details 
When displaying the video in the thread, the bounding box is wider than the thumbnail.

Remember that when providing full set of thumbnails, the proportion of the video thumbnail was modified.

Attaching screenshot that illustrates.
Blocks: 872514
blocking-b2g: --- → leo?
Blocking and passing to David Scravaglieri for help with assignment.

This is ugly and may hit us back during certification process.
Assignee: nobody → dscravaglieri
blocking-b2g: leo? → leo+
Whiteboard: [u=commsapps-user c=messaging p=0]
cc Fabien who did the bulk of the thumbnail display code
Depends on: 889899
as expected, this got fixed by the patch in bug 884975.

(I never know if I should dupe in that case)
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Assignee: dscravaglieri → nobody
blocking-b2g: leo+ → leo?
Whiteboard: [u=commsapps-user c=messaging p=0] → [u=commsapps-user c=messaging p=0],[leo-triage]
Priority: -- → P1
Target Milestone: --- → 1.1 QE5
we moved to leo? because the defect, which mentioned in comment 3 which fixes this issue is hd+ and not for leo
Target Milestone: 1.1 QE5 → 1.1 QE4 (15jul)
oh right, then I'll reopen here, we need to put the part of the patch that fixed this in v1.1 as well.

Steve, do you feel like doing this ?
Assignee: nobody → schung
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Just made bug 884975 leo+ so that we can dupe this one.
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → DUPLICATE
Thanks Wayne, Uplifting bug 884975 should work. If conflict occur while patch uplift, I will fix that.
blocking-b2g: leo? → leo+
Whiteboard: [u=commsapps-user c=messaging p=0],[leo-triage] → [u=commsapps-user c=messaging p=0]
Based on bug 884975 comment 26, v1-train will not handle device pixel issue and all the 1.5X images should not exist in this branch. Reopen this one to remove all the unused images for fixing the issue properly.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Attached file Link to github — 
Hi Rex, the main problem already fixed by uplifting bug 884975, but it will leave unused 1.5x images in v1-train. Could you confirm that removing these 1.5x images is safe in v1-train? Thanks.
Attachment #776943 - Flags: review?(rexboy)
Comment on attachment 776943 [details]
Link to github

Looks safe. r=me


thanks for your work!
Attachment #776943 - Flags: review?(rexboy) → review+
Landed in v1-train : https://github.com/mozilla-b2g/gaia/commit/c506c50adaaebcf729ac3c27887ba2931ab79040
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
The size of the video thumbnail is ok.
Verified with unagi device v1-train 07/17 build:
Gecko-2d17cfb
Gaia-c506c50
ref. ril
Status: RESOLVED → VERIFIED
Whiteboard: [u=commsapps-user c=messaging p=0] → [u=commsapps-user c=messaging p=0], [LeoVB+]
v1.1.0hd: c506c50adaaebcf729ac3c27887ba2931ab79040
v1.1.0hd: 71777eb9ce478f9f62978d8bea3d4c67a36417c3
status-b2g-v1.1hd: --- → fixed
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: