Silent exception when inspecting debugger variables on old actors (b2g-18 ones)

RESOLVED FIXED in Firefox 25

Status

defect
P2
normal
RESOLVED FIXED
6 years ago
11 months ago

People

(Reporter: ochameau, Assigned: ochameau)

Tracking

unspecified
Firefox 25

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
While working bug 817580, I noticed that variable inspection was silently failing when being connected on old actors (using m-c 18 branch). Both sides seem to work correctly as exchanged packets look correct:

{"to":"conn1.child1016:obj55","type":"prototypeAndProperties"}                
=>
{"from":"conn1.child1016:obj55","prototype":{"type":"object","class":"Object","actor":"conn1.child1016:obj84"},"ownProperties":{"name":{"configurable":true,"enumerable":true,"writable":true,"value":"touchStartedState"},"init":{"configurable":true,"enumerable":true,"writable":true,"value":{"type":"object","class":"Function","actor":"                   | conn1.child1016:obj33"}},"touchstart":{"configurable":true,"enumerable":true,"writable":true,"value":{"type":"object","class":"Function","actor":"conn1.child1016:obj80"}},"touchmove":{"configurable":true,"enumerable":true,"writable":true ,"value":{"type":"object","class":"Function","actor":"conn1.child1016:obj81"}},"touchend":{"configurable":true,"enumerable":true,"writable":true,"value":{"type":"object","class":"Function","actor":"conn1.child1016:obj82"}},"holdtimeout":        {"configurable":true,"enumerable":true,"writable":true,"value":{"type":"object","class":"Function","actor":"conn1.child1016:obj83"}}}}

But this code is throwing an exception:
http://mxr.mozilla.org/mozilla-central/source/browser/devtools/shared/widgets/VariablesViewController.jsm#126
  let { ownProperties, prototype, safeGetterValues } = aResponse;

As b2g18's actor doesn't send the safeGetterValues property...
(Assignee)

Comment 2

6 years ago
Comment on attachment 770814 [details] [diff] [review]
Silent exception when inspecting debugger variables on old actors

Review of attachment 770814 [details] [diff] [review]:
-----------------------------------------------------------------

That was the issue I was refering to today on irc!
With that I can inspect variable on b2g18 from firefox nightly \o/
Attachment #770814 - Flags: review?(past)
(Assignee)

Updated

6 years ago
Blocks: 817580
Comment on attachment 770814 [details] [diff] [review]
Silent exception when inspecting debugger variables on old actors

Review of attachment 770814 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch!
Attachment #770814 - Flags: review?(past) → review+
Status: NEW → ASSIGNED
Priority: -- → P2
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/849066268881
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 25

Updated

11 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.