889896 - Data sharing toggle should honor locked preferences

Status: RESOLVED INVALID

(Firefox Health Report Graveyard :: Web: Health Report, defect, P4)

Description

[Gregory Szorc [:gps]]

+++ This bug was initially created as a clone of Bug #873054 +++

It's possible for system administrators to lock the preference that allows FHR to upload data. If this preference is locked, that should be reflected in about:healthreport somehow.

I believe this will require Firefox to send an additional piece of metadata into the about:healthreport iframe. We can do that all in this bug or create separate bugs.

Comment 1

[Gregory Szorc [:gps]]

Attachment: Pass upload locked flag to about:healthreport iframe

Pretty simple change. The existing test actually passed without
modifications. So, I added an Object.keys() in there to ensure tests
break if we ever add more things to the prefs payload.

Comment 2

[Mike Kaply [:mkaply]]

Is there a reason this didn't go in?

Is this still needed?

Comment 3

[Georg Fritzsche [:gfritzsche]]

Presumably this was dropped over other things and forgotten.

This still stands: You can still toggle the data upload in about:healthreport content even when the pref is locked, so the UI should reflect this.

Comment 4

[Mike Kaply [:mkaply]]

I'm just wondering if this page is going away with the changes to FHR and telemtry

Comment 5

[Georg Fritzsche [:gfritzsche]]

It was updated to be backed by the Telemetry data.
We still use the "Health Report" terminology for user-facing elements - for users nothing major changed, we just migrated to a different data reporting system in the background.

Comment 6

[Georg Fritzsche [:gfritzsche]]

The Health Report page went away in bug 1352497.