Closed
Bug 889927
Opened 12 years ago
Closed 12 years ago
Up/Down arrows circumvent Popcorn updating functionality
Categories
(Webmaker Graveyard :: Popcorn Maker, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mjschranz, Assigned: mjschranz)
Details
Attachments
(1 file)
Basically it's causing unnecessary recreates of the events themselves rather than just updating zindex.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #772056 -
Flags: review?(david.humphrey)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 772056 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/94
This is fine. Can I ask that while you're doing this, you also go and add a comment to public/src/core/track.js that explains what the second arg is doing? We don't have it documented, and the code isn't overly obvious.
R+ with that.
Attachment #772056 -
Flags: review?(david.humphrey) → review+
|
||
Comment 3•12 years ago
|
||
Commit pushed to master at https://github.com/mozilla/popcorn.webmaker.org
https://github.com/mozilla/popcorn.webmaker.org/commit/510edfdf5351ad09114da5006907a583e833024d
Fix Bug 889927 - Up/Down keys no longer destroy trackevent when just updating zindex
|
|
||
Updated•12 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•12 years ago
|
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in
before you can comment on or make changes to this bug.
Description
•