Closed
Bug 889982
Opened 11 years ago
Closed 11 years ago
Building popcorn-complete includes wrapper scripts in an incorrect order
Categories
(Webmaker Graveyard :: popcorn.js, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: thecount, Assigned: thecount)
Details
Attachments
(1 file)
You can see this if you run the testing mirror on complete. You can do this by: 1. running make testing 2. going to dist/testing-mirror/test/core.html You'll see it fails on not finding the prototype wrapper. This is because it builds youtube first, which needs the prototype wrapper. We should ensure the prototype wrapper is added first.
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → scott
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #770948 -
Flags: review?(schranz.m)
Updated•11 years ago
|
Attachment #770948 -
Flags: review?(schranz.m) → review+
Assignee | ||
Comment 2•11 years ago
|
||
Staged: https://github.com/mozilla/popcorn-js/commit/01c7760701e0fa4e82cb4c2980b3a1f0aa371dcf
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in
before you can comment on or make changes to this bug.
Description
•