890065 - Add a flag for optionally disabling sources.xml

Status: RESOLVED FIXED

(Firefox OS Graveyard :: GonkIntegration, defect)

Description

[Diego Wilson [:diego]]

Patch in github coming up

Comment 1

[Diego Wilson [:diego]]

PR here https://github.com/mozilla-b2g/gonk-misc/pull/101

Comment 2

[Diego Wilson [:diego]]

Attachment: Pull request

Comment 3

[Michael Wu [:mwu]]

What problem is this fixing?

Comment 4

[Michael Vines [:m1] [:evilmachines]]

(besides the core manifest problem that Diego is trying to address, an option to disable sources.xml is also nice as that build step runs very slowly on my machine sometimes, 5minutes!, and we don't use it in any way)

Comment 5

[Diego Wilson [:diego]]

Re: core manifest problem.

|make sources.xml| does not know how to parse certain manifests. For example: it fails to interpret <remove-project> elements.

We could try to patch it. But I think the problem resides on the fact that it tries to parse manifests using its own script. This is IMO *very* error prone and hard to maintain. The patch serves as a quick stopgap, and as m1 mentioned, we don't need this for some builds anyway.

FWIW I think |make sources.xml| needs to be revamped to use |repo manifest -o|. This may not be trivial.

Comment 6

[Michael Wu [:mwu]]

Agreed on using repo manifest. We also have automation which depends on sources.xml which may make things trickier if we do try to switch over.

m1, does repo manifest run faster on your machine? It appears to take about a second here. If that's fast enough we can avoid adding another build knob.

Comment 7

[Michael Wu [:mwu]]

Comment on attachment 772717 [details]
Pull request

I don't mind adding this as a stop gap, though I generally do not like adding more build variables to fiddle with since they're not particularly easy to discover.

Comment 8

[Michael Vines [:m1] [:evilmachines]]

Running |repo manifest -r| is also a dog run my machine, maybe I don't git-gc often enough or something.

Comment 9

[Michael Vines [:m1] [:evilmachines]]

https://github.com/mozilla-b2g/gonk-misc/commit/56f756d207db2a13bb4981edcbb55bc5f28cbdb5

Comment 10

[Diego Wilson [:diego]]

First try didn't stick. Trying again.

Comment 11

[Diego Wilson [:diego]]

Attachment: Pull request - v2

Comment 12

[Michael Vines [:m1] [:evilmachines]]

https://github.com/mozilla-b2g/gonk-misc/commit/8b697d27f243272a0ff0567def8be3eb466d6396

letshopethisfinallysticks!