890124 - about:home shouldn't display (e.g.) Firefox OS campains in unbranded/rebranded builds

Status: NEW

(Firefox :: General, defect)

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Why not?

If you're just saying that the snippets service URL should be defined in the branding package, I suppose I don't have any objection, but it's hardly the only in-product URL that isn't easily customizable :/

Comment 2

[Mike Hommey [:glandium]]

(In reply to :Gavin Sharp (use [e-mail] for email) from comment #1)
> Why not?

Because it looks weird to start iceweasel and see the firefox os logo replace iceweasel's.

> If you're just saying that the snippets service URL should be defined in the
> branding package, I suppose I don't have any objection, but it's hardly the
> only in-product URL that isn't easily customizable :/

It's not the first and won't be last, but at least it's identified and fixable.

Comment 3

[Justin Dolske [:Dolske]]

I would expect a non-Firefox product to adjust browser.aboutHomeSnippets.updateUrl to either point to their own service or a blank URL (which would presumably not load any snippets).

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

well, we still have bug 855461 and bug 632264. about:home has been built very firefox-y with the idea others could have just set their own home page.
Not just the snippets but also the buttons opening tools at the bottom of the page may not be valid for any product.

Comment 5

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

provided we could #ifdef MOZ_OFFICIAL_BRANDING the code that unhides the default snippets and then just setting the updateURL to something else may work for this case?