89017 - PredicateList::evaluatePredicates isn't nifty

Status: VERIFIED FIXED

(Core :: XSLT, defect)

Description

[Axel Hecht]

The use of NodeSet::remove is sad, and it's prolly slow for foo[6].
The code should be redone.

Assigning to me

Axel

Comment 1

[Axel Hecht]

attaching patch.
this has:
 code cleanup
 ListIterator pattern changed from heap to stack, no new. use txListIterator
 added assertion for null checks
 optimize code in the respect that we don't check for duplicates in NodeSets.
  This isn't needed, as we don't deal with any Node, that hasn't been part of
  the NodeSet already. (restore that at the end).

I didn't go for switching the two NodeSets, basically for three reasons:
We have to modify the original NodeSet, so I had to keep track of which is the
current one. For uneven number of predicates, we still have to copy, so the 
case of one predicate doesn't gain any profit. And we had to switch the context
nodeset in each run.
--> not worth the trouble IMHO.

Axel

Comment 2

[Axel Hecht]

Attachment: patch to source/xpath/PredicateList.cpp

Comment 3

[Peter Van der Beken [:peterv]]

r=peterv. Now send me that 100 DM you promised me for this r stamp.

Comment 4

[Axel Hecht]

and I thought you wanna get rid of dying currencies. Here you go:
100 DM.

Axel

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

r=sicking

Comment 6

[Johnny Stenback (:jst)]

sr=jst, I'm thinking I need some of those DM's too by now :-)

Comment 7

[Axel Hecht]

fix checked in, made mental note to ship some DM to jst next year.

Axel

Comment 8

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

have you sent those 100DM yet?