nsSystemTimeChangeObserver::RemoveWindowListenerImpl leaks the weak reference

RESOLVED FIXED in mozilla25

Status

()

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Ms2ger, Assigned: Ehsan)

Tracking

({memory-leak})

Trunk
mozilla25
memory-leak
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

1015 bytes, patch
justin.lebar+bug
: review+
Details | Diff | Splinter Review
(Reporter)

Description

6 years ago
NS_GetWeakReference returns an already-addrefed raw pointer, which isn't released. Prefer do_GetWeakReference.
Ccing code author and reviewer...
Flags: needinfo?(slee)
Flags: needinfo?(justin.lebar+bug)
(Assignee)

Comment 2

6 years ago
Created attachment 771367 [details] [diff] [review]
Patch (v1)
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #771367 - Flags: review?(justin.lebar+bug)
Comment on attachment 771367 [details] [diff] [review]
Patch (v1)

r=me; thanks for catching this.
Attachment #771367 - Flags: review?(justin.lebar+bug) → review+
Flags: needinfo?(slee)
Flags: needinfo?(justin.lebar+bug)
https://hg.mozilla.org/mozilla-central/rev/60eb83902698
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.