890245 - Addons icon keep disappearing after restart of browser

Status: RESOLVED WORKSFORME

(Firefox :: Toolbars and Customization, defect)

Description

[RyanTheUXLover]

Attachment: beforerestart.jpg

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:25.0) Gecko/20130702 Firefox/25.0 (Nightly/Aurora)
Build ID: 20130702040201

Steps to reproduce:

1. installed HellBoy Firewall addon and DownloadThemAll addon
2. closed the browser
3. restarted the browser


Actual results:

hellboy firewall and downloadthemall icon which i put at the side of awesome bar was gone


Expected results:

the icons should have never disappeared

Comment 1

[RyanTheUXLover]

Attachment: afterrestart.jpg

Comment 2

[RyanTheUXLover]

Comment on attachment 771312 [details]
afterrestart.jpg

i actually removed the icons myself in this pic becoz i just wanna show how it looks like after restart and becoz i can't quit my browser while in a middle of submitting a bug

Comment 3

[:Gijs (he/him)]

Marked P2 on the supposition that these add-ons aren't doing anything crazy, and there's something in our customizableUI code that means we're not restoring them properly. This might not be a very solid assumption. I don't have time to look right now, but I can have a closer look once we've worked through our performance blockers.

Comment 4

[:Gijs (he/him)]

Trying to reproduce this. I can see the hellboy firewall icon going away, but haven't been able to investigate why that is yet. I can't reproduce the issue with DTA; once I've added the icons (all 4 of them...) to the toolbar, before the awesomebar, they all stay there just fine.

Comment 5

[:Gijs (he/him)]

The Hellboy issue might go away after fixing bug 887438, but it's possible it'll require more work on the add-on author's part to make this work. Marking the dependency for now, and then we can resolve as appropriate if/when that bug lands.

Comment 6

[:Gijs (he/him)]

Egh. The add-on in question disappeared off addons.mozilla.org. :-\

I'm faaaaaiiiirly sure this got fixed, so I'm going to mark as WFM. Please reopen if you can still reproduce with other add-ons. Thank you! :-)