890248 - Avoid races with PlayingRefChangedHandler

Status: RESOLVED FIXED

(Core :: Web Audio, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

See https://bugzilla.mozilla.org/show_bug.cgi?id=890072#c3.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

Comment 2

[(no longer active)]

Comment on attachment 771354 [details] [diff] [review]
fix

Review of attachment 771354 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/webaudio/ConvolverNode.h
@@ +43,5 @@
> +  {
> +    mMediaStreamGraphUpdateIndexAtLastInputConnection =
> +      mStream->Graph()->GetCurrentGraphUpdateIndex();
> +  }
> +  bool AcceptPlayingRefRelease(int64_t aLastGraphUpdateIndexProcessed)

Nit: const.

@@ +45,5 @@
> +      mStream->Graph()->GetCurrentGraphUpdateIndex();
> +  }
> +  bool AcceptPlayingRefRelease(int64_t aLastGraphUpdateIndexProcessed)
> +  {
> +    return aLastGraphUpdateIndexProcessed >= mMediaStreamGraphUpdateIndexAtLastInputConnection;

Please add a comment here explaining what this check does (for DelayNode too)

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ed581b59499b

Comment 4

[(no longer active)]

Please land on Aurora with a=webaudio.  Thanks!

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/54741e3ae917

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ed581b59499b

Comment 7

[u279076]

Assuming no verification needed here. Please add the verifyme keyword and remove the [qa-] whiteboard tag to request verification.