Avoid races with PlayingRefChangedHandler

RESOLVED FIXED in Firefox 24

Status

()

Core
Web Audio
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: roc, Assigned: roc)

Tracking

Trunk
mozilla25
x86_64
Linux
Points:
---

Firefox Tracking Flags

(firefox24 fixed, firefox25 fixed)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

See https://bugzilla.mozilla.org/show_bug.cgi?id=890072#c3.
Version: 18 Branch → Trunk
Created attachment 771354 [details] [diff] [review]
fix
Attachment #771354 - Flags: review?(ehsan)

Comment 2

5 years ago
Comment on attachment 771354 [details] [diff] [review]
fix

Review of attachment 771354 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/webaudio/ConvolverNode.h
@@ +43,5 @@
> +  {
> +    mMediaStreamGraphUpdateIndexAtLastInputConnection =
> +      mStream->Graph()->GetCurrentGraphUpdateIndex();
> +  }
> +  bool AcceptPlayingRefRelease(int64_t aLastGraphUpdateIndexProcessed)

Nit: const.

@@ +45,5 @@
> +      mStream->Graph()->GetCurrentGraphUpdateIndex();
> +  }
> +  bool AcceptPlayingRefRelease(int64_t aLastGraphUpdateIndexProcessed)
> +  {
> +    return aLastGraphUpdateIndexProcessed >= mMediaStreamGraphUpdateIndexAtLastInputConnection;

Please add a comment here explaining what this check does (for DelayNode too)
Attachment #771354 - Flags: review?(ehsan) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/ed581b59499b
tracking-firefox24: --- → ?

Comment 4

5 years ago
Please land on Aurora with a=webaudio.  Thanks!
status-firefox24: --- → affected
status-firefox25: --- → fixed
tracking-firefox25: --- → ?
Keywords: checkin-needed
https://hg.mozilla.org/releases/mozilla-aurora/rev/54741e3ae917
status-firefox24: affected → fixed
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/ed581b59499b
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25

Updated

5 years ago
tracking-firefox24: ? → ---
tracking-firefox25: ? → ---
Assuming no verification needed here. Please add the verifyme keyword and remove the [qa-] whiteboard tag to request verification.
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.