890266 - Better perf when there are many clips trying to be loaded at once

Status: RESOLVED FIXED

(Webmaker Graveyard :: Popcorn Maker, defect)

Description

[Scott [:thecount] Downe]

If you have a project with lots of clips being loaded all at the same time, and you hit play before they are all loaded, it can pretty much bring down that tab.

An example is about to follow.

Warning, probably best to not hit play on that until it is loaded. It is not a fun experience. You've been warned.

See this link for an example as to what I mean: https://popcorn.webmaker.org/editor/56810/remix

Comment 1

[Scott [:thecount] Downe]

Attachment: https://github.com/mozilla/popcorn.webmaker.org/pull/90

Now that we have a loading handler, this was soo much easier.

Comment 2

[Scott [:thecount] Downe]

Comment on attachment 771356 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/90

Cade said he had time right now.

Comment 3

[Chris DeCairos (:cade)]

Comment on attachment 771356 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/90

R+

Please file a bug for Soundcloud Autoplaying/forcing a reload of all media and a bug for YT not being hidden while being loaded.

Comment 4

[Scott [:thecount] Downe]

Comment on attachment 771356 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/90

I want one more reviewer.

Comment 5

[Scott [:thecount] Downe]

As per Chris' request, filed bug 890296 and bug 890301.

Comment 6

[Scott [:thecount] Downe]

Staged: https://github.com/mozilla/popcorn.webmaker.org/commit/b6bd8612511c8e46a4abb07c658ff6d9a11678cb