We should be able to download whatever object was downloaded
Categories
(DevTools :: Netmonitor, enhancement, P3)
Tracking
(Not tracked)
People
(Reporter: julienw, Unassigned)
References
Details
Attachments
(1 file)
Comment 1•12 years ago
|
||
Updated•12 years ago
|
Updated•12 years ago
|
Reporter | ||
Updated•11 years ago
|
Comment 3•11 years ago
|
||
Reporter | ||
Comment 4•11 years ago
|
||
Comment 5•11 years ago
|
||
Comment 6•11 years ago
|
||
Updated•7 years ago
|
Comment 7•5 years ago
|
||
Honza, since we have Save as Image, do you think this a good first bug?
Comment 8•5 years ago
|
||
Some instructions for anyone interested in fixing this bug
-
We want to implement "Save Response As" context menu item for HTTP requests in the list. Similarly to "Save Image As" we have for images.
Here is the context menu items list with "SaveImageAs" method
https://searchfox.org/mozilla-central/rev/a37fc61f172b432e7ae0b6b4c4a12cac2a787a0f/devtools/client/netmonitor/src/widgets/RequestListContextMenu.js#272 -
Here is the
saveImageAs
helper
https://searchfox.org/mozilla-central/rev/a37fc61f172b432e7ae0b6b4c4a12cac2a787a0f/devtools/client/netmonitor/src/widgets/RequestListContextMenu.js#655 -
Here is the
saveAs
helper
https://searchfox.org/mozilla-central/rev/a37fc61f172b432e7ae0b6b4c4a12cac2a787a0f/devtools/shared/DevToolsUtils.js#812 -
Here is how
copyResponse
is done, we should do the same when saving the response to a file
https://searchfox.org/mozilla-central/rev/a37fc61f172b432e7ae0b6b4c4a12cac2a787a0f/devtools/client/netmonitor/src/widgets/RequestListContextMenu.js#683
Honza
Comment 9•5 years ago
|
||
I'm interested in fixing this bug.
Comment 10•5 years ago
|
||
Assigned to you, thanks for the help!
Honza
Comment 11•5 years ago
|
||
Honza, how should be named the access key for the saving response property in the context menu?
On the netmonitor.properties, the label for saving an image has the 'v' as the access key.
Could it be a 'r' for saving a response?
Thanks in advance!
Comment 12•5 years ago
|
||
Also, are there tests for this part of the code? (The context menu)
And if so, where should I write the tests for the save response context menu?
Comment 13•5 years ago
|
||
Comment 15•5 years ago
|
||
@Nicolas: do we have an existing test that could be used as source for inspiration for testing Save As
context menu item?
Honza
Comment 16•5 years ago
|
||
Ah, just found it:
https://searchfox.org/mozilla-central/rev/d5b34cc8872177d3ee071e06f787c2a14268595b/devtools/client/jsonview/test/browser_jsonview_save_json.js#35
Honza
Comment 17•5 years ago
|
||
Thanks Honza!
Comment 18•5 years ago
|
||
@Honza, any feedbacks on the new update I've sent?
Comment 20•5 years ago
|
||
I posted feedback to Phab
https://phabricator.services.mozilla.com/D64915#2022281
Honza
Comment 21•5 years ago
|
||
Mariana, you are assigned to this bug, but there is no activity for a long time.
Looks like we just need a test for this.
Are you planning to work on this?
Honza
Updated•4 years ago
|
Comment 22•3 years ago
|
||
The bug assignee didn't login in Bugzilla in the last 7 months.
:Honza, could you have a look please?
For more information, please visit auto_nag documentation.
Comment 23•3 years ago
|
||
Would be still good to have this, but not a priority for the team atm.
Comment 24•3 years ago
|
||
Redirect a needinfo that is pending on an inactive user to the triage owner.
:Honza, since the bug has recent activity, could you please find another way to get the information or close the bug as INCOMPLETE
if it is not actionable?
For more information, please visit auto_nag documentation.
Description
•