Open Bug 890286 Opened 12 years ago Updated 3 years ago

We should be able to download whatever object was downloaded

Categories

(DevTools :: Netmonitor, enhancement, P3)

21 Branch
enhancement

Tracking

(Not tracked)

People

(Reporter: julienw, Unassigned)

References

Details

Attachments

(1 file)

STR: * go to the network panel and have some network requests/responses there * try to download one of the downloaded objects I want to be able to download what was already downloaded, both from the main request list view and from the "response" panel on the right.
I think a "save as" context menu item would be a good fit here.
Priority: P1 → --
OS: Linux → All
Priority: -- → P2
Hardware: x86_64 → All
per Paul's request
Depends on: gaia-devtools
No longer depends on: gaia-devtools
We now have an "Open in new tab" context menu item for this. Would that be sufficient?
Flags: needinfo?(felash)
It's better but "Save as" is more useful than open in new tab in most cases IMO. So I think both options are necessary.
Flags: needinfo?(felash)
I think the "Save as" context menu would be a good addition, too. Similarly, it would be handy if the image preview in the "Response" tab also had a context menu available, with the typical actions.
(In reply to Dane MacMillan from comment #5) > I think the "Save as" context menu would be a good addition, too. Similarly, > it would be handy if the image preview in the "Response" tab also had a > context menu available, with the typical actions. Bug 966209.
Product: Firefox → DevTools

Honza, since we have Save as Image, do you think this a good first bug?

Type: defect → enhancement
Flags: needinfo?(odvarko)
Priority: P2 → P3

Some instructions for anyone interested in fixing this bug

  1. We want to implement "Save Response As" context menu item for HTTP requests in the list. Similarly to "Save Image As" we have for images.
    Here is the context menu items list with "SaveImageAs" method
    https://searchfox.org/mozilla-central/rev/a37fc61f172b432e7ae0b6b4c4a12cac2a787a0f/devtools/client/netmonitor/src/widgets/RequestListContextMenu.js#272

  2. Here is the saveImageAs helper
    https://searchfox.org/mozilla-central/rev/a37fc61f172b432e7ae0b6b4c4a12cac2a787a0f/devtools/client/netmonitor/src/widgets/RequestListContextMenu.js#655

  3. Here is the saveAs helper
    https://searchfox.org/mozilla-central/rev/a37fc61f172b432e7ae0b6b4c4a12cac2a787a0f/devtools/shared/DevToolsUtils.js#812

  4. Here is how copyResponse is done, we should do the same when saving the response to a file
    https://searchfox.org/mozilla-central/rev/a37fc61f172b432e7ae0b6b4c4a12cac2a787a0f/devtools/client/netmonitor/src/widgets/RequestListContextMenu.js#683

Honza

Flags: needinfo?(odvarko)
Keywords: good-first-bug

I'm interested in fixing this bug.

Assigned to you, thanks for the help!

Honza

Assignee: nobody → marianapicolo
Status: NEW → ASSIGNED

Honza, how should be named the access key for the saving response property in the context menu?

On the netmonitor.properties, the label for saving an image has the 'v' as the access key.

Could it be a 'r' for saving a response?


Thanks in advance!

Also, are there tests for this part of the code? (The context menu)
And if so, where should I write the tests for the save response context menu?

ni? Honza for Mariana's questions ^

Flags: needinfo?(odvarko)

@Nicolas: do we have an existing test that could be used as source for inspiration for testing Save As context menu item?

Honza

Flags: needinfo?(odvarko) → needinfo?(nchevobbe)

Thanks Honza!

@Honza, any feedbacks on the new update I've sent?

https://phabricator.services.mozilla.com/D64915#2001640

cc'ing Honza for comment 18

Flags: needinfo?(odvarko)

Mariana, you are assigned to this bug, but there is no activity for a long time.
Looks like we just need a test for this.

Are you planning to work on this?

Honza

Flags: needinfo?(marianapicolo)

The bug assignee didn't login in Bugzilla in the last 7 months.
:Honza, could you have a look please?
For more information, please visit auto_nag documentation.

Assignee: marianapicolo → nobody
Status: ASSIGNED → NEW
Flags: needinfo?(odvarko)

Would be still good to have this, but not a priority for the team atm.

Flags: needinfo?(odvarko)

Redirect a needinfo that is pending on an inactive user to the triage owner.
:Honza, since the bug has recent activity, could you please find another way to get the information or close the bug as INCOMPLETE if it is not actionable?

For more information, please visit auto_nag documentation.

Flags: needinfo?(marianapicolo) → needinfo?(odvarko)

Still valid bug

Severity: normal → S3
Flags: needinfo?(odvarko)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: