56 bytes, text/x-github-pull-request
|Details | Review | Splinter Review|
"OPTIMIZE_JS" set to true in local.json fixes mixed content issues for exported projects. Without it, the js files are all seperate files, living on localhost, and the export is on https on amazon. This causes the mixed content issue. For some reason the way we do "OPTIMIZE_JS" it fixes this. I am guessing it makes one js file and sends it off to be hosted on amazon? This is only an issue for devs, using localhost. It is annoying and we should think of a solution.
Summary: OPTIMIZE_JS option in popcorn maker is used to solve mixed content issues → OPTIMIZE_JS option in popcorn maker is used to solve cross origin loading issues
So apparently this patch isn't necessary at all, and master works fine without OPTIMIZE_JS: true
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → INVALID
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.