Closed
Bug 890297
Opened 8 years ago
Closed 8 years ago
Update Webmaker LoginAPI Module
Categories
(Webmaker Graveyard :: MakeAPI, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mjschranz, Assigned: mjschranz)
References
Details
Attachments
(1 file)
We updated the module and SSO in 884681 and need to update this accordingly to prevent things from breaking.
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #771375 -
Flags: review?(chris)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 771375 [details] [review] https://github.com/mozilla/MakeAPI/pull/103 r+
Attachment #771375 -
Flags: review?(chris) → review+
|
||
Comment 3•8 years ago
|
||
Commit pushed to master at https://github.com/mozilla/MakeAPI https://github.com/mozilla/MakeAPI/commit/048ff6017d353af45bb655f5b7075f4ae5e65d18 Fix Bug 890297 - Update webmaker-loginapi module to 0.1.8
|
|
||
Updated•8 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 4•8 years ago
|
||
There was one change needed at Chris' R+. I noticed we don't apply CSRF as app level middleware so I needed to make it used the 0.1.8 version of the module and pass along the csrf middleware to the module! R+ from :sedge
|
|
||
Comment 5•8 years ago
|
||
Commit pushed to master at https://github.com/mozilla/webmaker.org https://github.com/mozilla/webmaker.org/commit/2c5abdd983adbd712da2b99a82e7ecc2a013727f Bug 890297 - Update webmaker-login to v0.1.8
|
||
Updated•8 years ago
|
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in
before you can comment on or make changes to this bug.
Description
•