Closed Bug 890342 Opened 11 years ago Closed 11 years ago

[SMS] LinkHelper regression: misrecognized links

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect, P1)

Product:
Firefox OS Graveyard
Component:
Gaia::SMS
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

(blocking-b2g:leo+, b2g18 fixed, b2g-v1.1hd fixed)

Status:
VERIFIED FIXED
Milestone:
1.1 QE4 (15jul)
Project Flags:
blocking-b2g leo+
Tracking Flags:
Tracking Status
b2g18 --- fixed
b2g-v1.1hd --- fixed

People

(Reporter: gerard-majax, Assigned: arcturus)

References

Details

(Keywords: regression, Whiteboard: [u=commsapps-user c=messaging p=1],[leo-triage], [LeoVB+] )

Attachments

(1 file)

Pointer to PR 10844
359 bytes, text/html
julienw
: review+
Details 
After landing of bug 870711, I get link for "2.74" and "21.72". Looks like the matching for IP addresses is breaking :)

This should be leo+ since bug 870711 was.
Depends on: 870711
Corey, could you take a look? Thanks!
Flags: needinfo?(gnarf37)
blocking-b2g: leo? → leo+
Priority: -- → P1
Assignee: nobody → francisco.jordano
Flags: needinfo?(gnarf37)
Whiteboard: [u=commsapps-user c=messaging p=1]
Status: NEW → ASSIGNED
Attached file Pointer to PR 10844 — 

        Attachment #772161 -
        Flags: review?(felash)

    
    

    
  
Comment on attachment 772161 [details]
Pointer to PR 10844

except the isNan part, I'm generally ok with this, but I'd like Corey to have a look as well as he did the original code.

I'll give r+ after Corey's feedback.

        Attachment #772161 -
        Flags: review?

        Attachment #772161 -
        Flags: feedback?(gnarf37)

    
    

    
  
Comment on attachment 772161 [details]
Pointer to PR 10844

r=me with the last nit

        Attachment #772161 -
        Flags: review?(felash)

        Attachment #772161 -
        Flags: review?

        Attachment #772161 -
        Flags: review+

        Attachment #772161 -
        Flags: feedback?(gnarf37)

    
    

    
  
Thanks folks,

landed here:

https://github.com/mozilla-b2g/gaia/commit/3ec4322b3f878750c64fb0b7cb35f1a0da1749d2
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED

    
    

    
  
Uplifted 3ec4322b3f878750c64fb0b7cb35f1a0da1749d2 to:
v1-train: 379e121904096ff3d8160ccd20f85267be214f5b

          status-b2g18:
          --- → fixed

    
    

    
  
Verified with unagi 07/11 v1-train build, ref ril:
Gecko-bd579ea
Gaia-680c72c
Status: RESOLVED → VERIFIED

    
  
blocking-b2g: leo+ → leo?
Whiteboard: [u=commsapps-user c=messaging p=1] → [u=commsapps-user c=messaging p=1],[leo-triage]

    
  
Target Milestone: --- → 1.1 QE5

    
    

    
  
why has this leo+ been reset ? it's already fixed, pushed, and uplifted.

    
  
blocking-b2g: leo? → leo+
Target Milestone: 1.1 QE5 → 1.1 QE4 (15jul)

    
  
Whiteboard: [u=commsapps-user c=messaging p=1],[leo-triage] → [u=commsapps-user c=messaging p=1],[leo-triage], [LeoVB+]

    
    

    
  
v1.1.0hd: 379e121904096ff3d8160ccd20f85267be214f5b

          status-b2g-v1.1hd:
          --- → fixed

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: