Closed Bug 890342 Opened 7 years ago Closed 7 years ago
Helper regression: misrecognized links
After landing of bug 870711, I get link for "2.74" and "21.72". Looks like the matching for IP addresses is breaking :) This should be leo+ since bug 870711 was.
Corey, could you take a look? Thanks!
Assignee: nobody → francisco.jordano
Whiteboard: [u=commsapps-user c=messaging p=1]
Comment on attachment 772161 [details] Pointer to PR 10844 except the isNan part, I'm generally ok with this, but I'd like Corey to have a look as well as he did the original code. I'll give r+ after Corey's feedback.
Comment on attachment 772161 [details] Pointer to PR 10844 r=me with the last nit
Thanks folks, landed here: https://github.com/mozilla-b2g/gaia/commit/3ec4322b3f878750c64fb0b7cb35f1a0da1749d2
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Uplifted 3ec4322b3f878750c64fb0b7cb35f1a0da1749d2 to: v1-train: 379e121904096ff3d8160ccd20f85267be214f5b
Verified with unagi 07/11 v1-train build, ref ril: Gecko-bd579ea Gaia-680c72c
Status: RESOLVED → VERIFIED
blocking-b2g: leo+ → leo?
Whiteboard: [u=commsapps-user c=messaging p=1] → [u=commsapps-user c=messaging p=1],[leo-triage]
why has this leo+ been reset ? it's already fixed, pushed, and uplifted.
Whiteboard: [u=commsapps-user c=messaging p=1],[leo-triage] → [u=commsapps-user c=messaging p=1],[leo-triage], [LeoVB+]
You need to log in before you can comment on or make changes to this bug.