Closed Bug 890356 Opened 11 years ago Closed 11 years ago

After leaving full-screen mode, toolbar buttons have no context menu

Categories

(Firefox :: Toolbars and Customization, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 28

People

(Reporter: jruderman, Assigned: Gijs)

References

(Blocks 1 open bug)

Details

(Keywords: regression, Whiteboard: [Australis:M8])

Attachments

(1 file)

1. Enter full-screen with ⌘^F
2. Exit  full-screen with ⌘^F
3. Right-click any toolbar button

Expected: Context menu with "Customize...", etc

Result: Nothing
This was broken by an oversimplification of browser-fullScreen.js in bug 863299. In showXULChrome, we should still check el.hasAttribute('saved-context'), because right now we always overwrite the value with an empty context attribute.
Depends on: 863299
Attached patch PatchSplinter Review
Attachment #771421 - Flags: review?(jaws)
Assignee: nobody → gijskruitbosch+bugs
Blocks: 863299
No longer depends on: 863299
Keywords: regression
Comment on attachment 771421 [details] [diff] [review]
Patch

>-          el.setAttribute("context", el.getAttribute("saved-context"));
>+          if (el.hasAttribute("saved-context")) {
>+            el.setAttribute("context", el.getAttribute("saved-context"));
>+          }
>           el.removeAttribute("saved-context");

Move removeAttribute up as well.
Attachment #771421 - Flags: review?(jaws) → review+
(In reply to Dão Gottwald [:dao] from comment #3)
> Comment on attachment 771421 [details] [diff] [review]
> Patch
> 
> >-          el.setAttribute("context", el.getAttribute("saved-context"));
> >+          if (el.hasAttribute("saved-context")) {
> >+            el.setAttribute("context", el.getAttribute("saved-context"));
> >+          }
> >           el.removeAttribute("saved-context");
> 
> Move removeAttribute up as well.

Done!

https://hg.mozilla.org/projects/ux/rev/0f8d8d9254ca
Status: NEW → ASSIGNED
Whiteboard: [Australis:M8][fixed-in-ux]
https://hg.mozilla.org/mozilla-central/rev/0f8d8d9254ca
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:M8][fixed-in-ux] → [Australis:M8]
Target Milestone: --- → Firefox 28
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: