Closed
Bug 890388
Opened 11 years ago
Closed 11 years ago
Implement language or location UI for localization
Categories
(Webmaker Graveyard :: webmaker.org, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: cassie, Assigned: alicoding)
References
Details
(Whiteboard: localization, uidesign,wb.localization)
Attachments
(2 files)
Need some UI that allows users to switch languages (maybe a flag dropdown). Should probably live in the header.
Assignee | ||
Comment 1•11 years ago
|
||
http://ejohn.org/blog/a-strategy-for-i18n-and-node/ This one is interesting :D
Assignee | ||
Updated•11 years ago
|
Whiteboard: localization, uidesign → localization, uidesign,wb.localization
Reporter | ||
Updated•11 years ago
|
Assignee: nobody → cassie
Reporter | ||
Comment 2•11 years ago
|
||
Here you go, Ali! Notice the here states for the languages (light blue/grey background highlights the selected language in the list, and the outline appears over the flag up top). This pdf shows the different UI for signed-in vs. not signed-in. For starting out with just a few languages, this can be a single column dropdown. Can we put in dummy content to see how it will expand, though? Kate/Gavin/Dale may know about a different, good flag sprite – the one here is up for change! Ideally we'll want one that is aesthetically flat, to match our UI (this one has a not-so-preferable gradient over the flags). Looking forward to seeing this with real content plugged in.
Reporter | ||
Comment 3•11 years ago
|
||
FYI we have decided to eliminate flags due to confusion around multiple languages for the same countries, or multiple countries for the same languages. Instead we'll replace with just the word, so "English >" Closing!
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 4•11 years ago
|
||
Cassie - do we need follow up bugs for the actual implementation of this in webmaker.org and the 3 tools?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 5•11 years ago
|
||
I would prefer this bug open until we are going to start on the implementation of the actual drop down list ready.
Reporter | ||
Comment 6•11 years ago
|
||
Ali, you can rephrase the title of this bug then and assign to yourself? I think my bit is done, although the implementation will need a design review.
Reporter | ||
Updated•11 years ago
|
Assignee: cassie → nobody
Summary: Need language or location UI for localization → Implement language or location UI for localization
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → ali
Assignee | ||
Updated•11 years ago
|
Status: REOPENED → ASSIGNED
Assignee | ||
Comment 7•11 years ago
|
||
Attachment #807363 -
Flags: review?(dale)
Comment 8•11 years ago
|
||
Comment on attachment 807363 [details] [review] https://github.com/mozilla/webmaker.org/pull/383 Code looks fine, tested & works locally.
Attachment #807363 -
Flags: review?(dale) → review+
Comment 9•11 years ago
|
||
Commit pushed to master at https://github.com/mozilla/webmaker.org https://github.com/mozilla/webmaker.org/commit/c08aaabaff1208d387e0b9bc76033e6ff5fb2cc3 bug890388 - UI language picker
Assignee | ||
Updated•11 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in
before you can comment on or make changes to this bug.
Description
•