Closed Bug 890409 Opened 6 years ago Closed 6 years ago

Intermittent browser_aboutHome.js | uncaught exception - UnknownError at chrome://browser/content/abouthome/aboutHome.js:219

Categories

(Firefox :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 25
Tracking Status
firefox24 --- fixed
firefox25 --- fixed

People

(Reporter: philor, Assigned: mak)

Details

(Keywords: intermittent-failure)

Attachments

(1 file, 1 obsolete file)

https://tbpl.mozilla.org/php/getParsedLog.php?id=24920144&tree=Mozilla-Inbound
Rev5 MacOSX Mountain Lion 10.8 mozilla-inbound debug test mochitest-browser-chrome on 2013-07-03 18:32:07 PDT for push 4937e561e40d
slave: talos-mtnlion-r5-020

18:34:57     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/browser_aboutHome.js | Got snippets map: { last-update: undefined, cached-version: undefined }
18:34:57  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/browser_aboutHome.js | uncaught exception - UnknownError at chrome://browser/content/abouthome/aboutHome.js:219
18:34:57     INFO -  Stack trace:
18:34:57     INFO -      JS frame :: chrome://mochikit/content/tests/SimpleTest/SimpleTest.js :: simpletestOnerror :: line 1136
18:34:57     INFO -      native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0
18:34:57     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/browser_aboutHome.js | Running test
18:34:57     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/browser_aboutHome.js | Health Reporter instance available.
18:34:57     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/browser_aboutHome.js | Console message: [JavaScript Error: "UnknownError" {file: "chrome://browser/content/abouthome/aboutHome.js" line: 219}]
18:34:57     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/browser_aboutHome.js | Searches provider is available.
18:34:57     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/browser_aboutHome.js | Have data for today.
18:34:57     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/browser_aboutHome.js | Have data for about home on this engine.
18:34:57     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/browser_aboutHome.js | Have searches recorded.
18:34:57     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/base/content/test/browser_aboutHome.js | Cleanup
hard to tell what's up here, luckily we didn't stop using NS_ENSURE_SUCCESS in this code so have sort of a pseudo stack.
indexedDB is failing executeStep(), could be a corrupt database or wrong time to query (SQLITE_BUSY), not easy to figure what's up still.
This is one of our top oranges in the last few days :-(
did we solve that issue that allows tests to remotely reach the snippets service when instead it should be disallowed?
btw, I see something strange locally, I will investigate that today.
assigning to help me track it.
Assignee: nobody → mak77
Disabled the test for now:

https://hg.mozilla.org/integration/fx-team/rev/1d25d844f899

Bug 867550 seems to have made this a little worse (read: easier to investigate) but it's still only failing at IndexedDB operations.
Considered these exceptions are somehow expected due to the async nature of indexedDB and the fact we explicitly accept it failing (we cannot handle them without big code complications that we don't need and we cannot predict them cause of the asynchronicity) I think we should just mark the test with ignoreAllUncaughtExceptions(). We are fine with that since it doesn't break the functionality of the feature.
Regarding my previous doubts, I noticed for some reason the new indexedDB browser addon didn't show contents of about:home, so I had doubt we were not properly storing data, but after manual querying in Scratchpad I can tell the data is there, it's just the addon not showing it. I will ask bent to check it.
Attached patch ignore exceptions patch v1 (obsolete) — Splinter Review
Attachment #774908 - Flags: review?(ttaubert)
Attachment #774908 - Attachment description: ignore exceptions bug → ignore exceptions patch v1
Attachment #774908 - Flags: review?(ttaubert) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/f4f2e5c32dc2
Whiteboard: [leave open][test disabled]
Target Milestone: --- → Firefox 25
I think I figured what may be the issue and I'm testing a new version of the patch on Try
https://tbpl.mozilla.org/?tree=Try&rev=1f932c727cce
Attached patch patch v2Splinter Review
Try looks happy enough, I retriggered bc a hundred times. I think we may try again with this.
The only relevant change from the previous patch is that I moved the doc.documentElement.getAttribute("searchEngineName") to a single place, cause I think the timeouts were due to us trying to get that attribute asynchronously at the wrong time, then we were passing undefined to  Services.search.getEngineByName, getting back null, thus trying to read null.identifier.
Attachment #774908 - Attachment is obsolete: true
Attachment #776337 - Flags: review?(ttaubert)
Attachment #776337 - Flags: review?(ttaubert) → review+
Whiteboard: [leave open][test disabled]
https://hg.mozilla.org/mozilla-central/rev/d80c320f522a
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
No longer depends on: 895288
You need to log in before you can comment on or make changes to this bug.