890434 - [Dialer] Impossible to silence an incoming call without rejecting it

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Leo]

1. Title : Impossible to silence an incoming call without rejecting it
2. Precondition : 
3. Tester's Action : Receive a call >> Check if it's possible to silence the call, without rejecting it
4. Detailed Symptom : There are no soft nor lateral keys to silence the call without rejecting it
5. Expected : There should be a soft key o lateral key dedicated to silence the cal
6. Reproducibility: Y
1) Frequency Rate : 100%
7. Gaia Master/v1-train : Reproduce
8. Gaia Revision : f2d6ed54a236e6e3b94f0abad9f0dacb8a1cc7b3
9. Personal email id : [e-mail]

Comment 1

[Leo]

The reason why I ask is we want to know whether it is issue or not
And, we want to know whether Moizlla implement or not

Comment 2

[Beatriz Rodríguez [:brg]]

testing with v1-train unagi build made today with Gecko-7e9bf57.Gaia-e251ee6, Mozilla RIL.
I can decrease the volumen of an incoming call using the volumen down key till I reach the silent mode.
I think this work as designed.

Comment 3

[Alex Keybl [:akeybl]]

product, can you confirm whether this is expected behavior for 1.0/1.1?

Comment 4

[Sandip Kamat]

(In reply to Alex Keybl [:akeybl] from comment #3)
> product, can you confirm whether this is expected behavior for 1.0/1.1?

Short answer, yes.

Referring to comment 2, I think the original bug is not about silencing the volume of an ongoing call or a ringtone, but an ask to silence the ringtone when you hit volume down one time. (Standard Android implementation). e.g. if the user is in a meeting and can't take the call.

This could be planned for a later release, but should not block 1.0.1/1.1.

Comment 5

[Beatriz Rodríguez [:brg]]

(In reply to Sandip Kamat from comment #4)
> (In reply to Alex Keybl [:akeybl] from comment #3)
> > product, can you confirm whether this is expected behavior for 1.0/1.1?
> 
> This could be planned for a later release, but should not block 1.0.1/1.1.

Thank you Sandip, I change the nomination to koi? accordingly

Comment 6

[Wilfred Mathanaraj [:WDM]]

we will pick this up for the product backlog for comms

Comment 7

[KM Lee [:rexboy] (inactivate after Sep. 22)]

By the discuss above and comms backlog, the excepted behavior should be
 - Tapping volume-down (or other keys?) should silence current incoming call
 - Ringtone volume of system is remain unchanged.
 - Only current incoming call becomes silence. User need to press the button again 
   if next incoming call raised.

And 
 - Should we also stop vibrating? I guess yes?
Let's ask UX for further confirming the expected behavior.

Comment 8

[Stephany Wilkes]

Flagging Francis since he is indisputable king of the Dialer spec. :)

Comment 9

[Stephany Wilkes]

Reassigning to Wilfred and Jacqueline to see if this is still an issue for 1.3.

Comment 10

[Anthony Ricaud (:rik)]

We discussed this for our backlog so definitely wanted from the team and I think we should do it in 1.3.

Comment 11

[Wilfred Mathanaraj [:WDM]]

this is on the nice to have list for v1.3 - if we fix the blockers we should definitely land this.

Comment 12

[Anthony Ricaud (:rik)]

I have a patch for this when pressing the power button or the volume down button.

Comment 13

[Anthony Ricaud (:rik)]

Attachment: https://github.com/mozilla-b2g/gaia/pull/14577

I'm touching a test in SMS to account for the move of a mock. Let me know if you'd like a SMS peer to review that part.

Comment 14

[Etienne Segonzac (:etienne)]

Comment on attachment 8345913 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/14577

r=me with the style change for the new system file.

Works like a charm :)

Comment 15

[Anthony Ricaud (:rik)]

https://github.com/mozilla-b2g/gaia/commit/34c8e31c0d406486a46479a2700b4ac58581ea3b

Tada ! No more excuses for ringtones during our meetings ;)

Comment 16

[(inactive after 6/18) Alive Kuo [:alive]]

I don't think this is a longterm solution. We should enable hardware button event for app but not use IAC. IAC is not strict enough, any app could pretend to have 'dialercomms' protocol.

Comment 18

[Vance Chen [:vchen][skype:vance.lucida][[e-mail]]]

Hi Anthony -

Some carriers are asking for this feature again, could we uplift the patch to 1.3 branch?

Thanks

Vance

Comment 19

[Anthony Ricaud (:rik)]

Comment on attachment 8345913 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/14577

I can certainly ask :)

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Feature
[User impact] if declined: Can't silence calls without rejecting them.
[Testing completed]: It is on master (and 1.4) for months now. Comes with unit tests.
[Risk to taking this patch] (and alternatives if risky): Worst case scenario, the feature doesn't work.
[String changes made]: None.

Comment 20

[Ryan VanderMeulen [:RyanVM]]

v1.3: https://github.com/mozilla-b2g/gaia/commit/1112dc5339467fb43ea5e596da89f5e4b9d93ecb