890437 - [keybaord] Keyboard doesnt hide and when moving from Everything.me scrren to Home screen

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Everything.me, defect, P1)

Description

[Leo]

[Title] Keyboard doesnt hide and when moving from Everything.me screen  to Home screen
2.Precondition : 
3.Tester's Action: Homescreen >> Everything.me Page  >> Search >> Input text >>
  close(x)button >> swipe left to move to Homescreen 
4. Detailed Symptom (ENG.) : Keyboard should hide when moving from Everything.me page to Home screen
5. GAIA version : 7c0e9b946b8779e1f48ce4e12fb149d326797fac
6. Expected : Keyboard should Hide when swiping from Everything.me to Homescreen
7.Reproducibility: Y
1)Frequency Rate : 100%
8.Comparison Results : 
1)Model Comparing : 
9. Attached files: 
1)Log : 
2)Test Contents : 
3)Video file :

Comment 1

[Leo]

Attachment: Attached Images for Issues

Comment 2

[Leo]

Produced in V1-train with 
Gaia version: 496465667717dd17d9f18b884493f0d1cdabbe55

Comment 3

[Kay Lee]

Please let me know the progress of this issue.

Comment 4

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

To resolve this issue, we should remove the focus from the input element when the user swipes to leave the everthing.me section or presses the [home] button.

I think this change should live within everything.me instead of keyboard app.

Comment 5

[Leo]

Attachment: Attached patch for hiding keyboard.

Hi Jason,
I have attached a patch to hide the keyboard in Everything.me
Can you please get it reviewed by Home screen Engineer.

Also I have 2 issues on Everything.me screen which I want to point out.
1. When keyboard Hides in Everything.me screen, home screen appears in place of keyboard
2. When swiped to move to homescreen, it takes a long time to hide the keyboard.
I m not sure , how much delay to put in, so I left this part.
Please check and give your comment.

Thank you

Comment 6

[Jason Smith [:jsmith]]

You would probably want [e-mail] to review that patch.

Comment 7

[Leo]

please check the attached patch.

Comment 8

[Ran Ben Aharon [:ranbena] EverythingMe]

I'm not sure the patch suggested is the right fix. I'm on it.

Comment 9

[Ran Ben Aharon [:ranbena] EverythingMe]

Attachment: Patch - redirect to github PR

Comment 10

[Ran Ben Aharon [:ranbena] EverythingMe]

I attached the PR for the simple fix. Still I would like my coworker (Evyatar) to review it and make sure there are no regressions.

Comment 11

[Ran Ben Aharon [:ranbena] EverythingMe]

Leo, it's good to land.

Comment 12

[Preeti Raghunath(:Preeti)]

This is good to land. Can we land this patch this week?

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://github.com/mozilla-b2g/gaia/commit/4afffd7122219fb99531e9e9a971299a2f16d72e

Comment 14

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 4afffd7122219fb99531e9e9a971299a2f16d72e to:
v1-train: 2c70d6b679c30b2bf0a572f25914ae793090f862