Closed Bug 890460 Opened 11 years ago Closed 11 years ago

[SMS] After deleting all the messages in particular thread,the 'TODAY' bar still exists in thread_list

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect)

ARM
Gonk (Firefox OS)
defect
Not set
minor

Tracking

(blocking-b2g:leo+, b2g18 verified, b2g-v1.1hd fixed)

RESOLVED FIXED
blocking-b2g leo+
Tracking Status
b2g18 --- verified
b2g-v1.1hd --- fixed

People

(Reporter: leo.bugzilla.gaia, Assigned: julienw)

References

Details

Attachments

(1 file, 1 obsolete file)

1. Title: After deleting all the messages in particular thread,the 'TODAY' bar still exists in thread_list
2. Precondition: Should have some messages with particular thread
3. Tester's Action:  1)Go to current thread 
                     2) Edit -> Select all -> Delete 
                     3) Check the screen
4. Detailed Symptom (ENG.) : 'TODAY' in the Day bar is still shown
5. Expected:  When all the messages are deleted,'TODAY' bar also should be deleted
6. Reproducibility: Y
1) Frequency Rate : 100%
7. Gaia Master/v1-train: Reproduced on v1-train
8. Gaia Revision:  613e69ee0a009399130ad2cbb8b9d0462cd1fc70
9. Personal email id: sasikala.paruchuri8@gmail.com
I will take a look. It seems to be related with the 'fixed-header'.
Assignee: nobody → fbsc
blocking-b2g: --- → leo?
I think this will be fixed by bug 885278 (incidently waiting for a review since 4 days).
Sorry, 5 days now.
Just checked that the fix for Bug 885278 fixes this bug as well.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → DUPLICATE
blocking-b2g: leo? → ---
Sadly bug 885278 was not fixing this issue. I've created a small patch which fix this. As this was part of a bug leo+ that was not fixed completely, I would mark this one as leo+ as well. Leo, could you take a look? Surgical patch which let us close the entire buggy functionality.
Status: RESOLVED → REOPENED
blocking-b2g: --- → leo?
Depends on: 885278
Flags: needinfo?(leo.bugzilla.gaia)
Resolution: DUPLICATE → ---
Attached file Surgical patch (obsolete) —
Attachment #774579 - Flags: review?(felash)
Hi Borja,
This issue was fixed with the patch available at Bug:885278.
But the Bug:890443 was not fixed that patch.
Please let me know if you need any information.
Thanks,
Flags: needinfo?(leo.bugzilla.gaia)
Attached patch patch v2Splinter Review
see also PR at https://github.com/mozilla-b2g/gaia/pull/10941
Assignee: fbsc → felash
Attachment #774579 - Attachment is obsolete: true
Attachment #774579 - Flags: review?(felash)
Attachment #774585 - Flags: review?(fbsc)
The STR for this patch is :
* have an empty thread list
* send a SMS
* go back to the thread list
* open the thread
* delete the message from the message view
* go back to the thread list

=> the "today" header is still there
Attachment #774585 - Flags: review?(fbsc) → review+
Surgical patch and neededin order to have everything related with the header working as expected. Leo we would need to fix this as is a followup of bug 885278 which was leo+ (without this is not working as expected). Could you take a look? Thanks!
Status: REOPENED → RESOLVED
Closed: 11 years ago11 years ago
Resolution: --- → FIXED
Blocks: 889207
this needs leo+ - it blocks a blocker
Blocks a blocker.
blocking-b2g: leo? → leo+
John, could you take this uplifting? Now is leo+. THanks!
Flags: needinfo?(jhford)
Flags: needinfo?(jhford)
This bug is verified fixed with the variables below. When deleting Multiple messages from 1 contact from within the sms thread or from the thread list, the header for TODAY is also deleted.


Build ID: 20130722070207
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/68fb0a2e0114
Gaia: 41d10fb10be6916e6554eb440d9a97130ef23ce0
Platform Version: 18.1
RIL Version: 01.01.00.019.158
v1.1.0hd: f6d1d3221ae5fbb0a576e539d271825658f2652b
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: