Closed
Bug 890460
Opened 11 years ago
Closed 11 years ago
[SMS] After deleting all the messages in particular thread,the 'TODAY' bar still exists in thread_list
Categories
(Firefox OS Graveyard :: Gaia::SMS, defect)
Tracking
(blocking-b2g:leo+, b2g18 verified, b2g-v1.1hd fixed)
RESOLVED
FIXED
blocking-b2g | leo+ |
People
(Reporter: leo.bugzilla.gaia, Assigned: julienw)
References
Details
Attachments
(1 file, 1 obsolete file)
2.14 KB,
patch
|
borjasalguero
:
review+
|
Details | Diff | Splinter Review |
1. Title: After deleting all the messages in particular thread,the 'TODAY' bar still exists in thread_list 2. Precondition: Should have some messages with particular thread 3. Tester's Action: 1)Go to current thread 2) Edit -> Select all -> Delete 3) Check the screen 4. Detailed Symptom (ENG.) : 'TODAY' in the Day bar is still shown 5. Expected: When all the messages are deleted,'TODAY' bar also should be deleted 6. Reproducibility: Y 1) Frequency Rate : 100% 7. Gaia Master/v1-train: Reproduced on v1-train 8. Gaia Revision: 613e69ee0a009399130ad2cbb8b9d0462cd1fc70 9. Personal email id: sasikala.paruchuri8@gmail.com
Comment 1•11 years ago
|
||
I will take a look. It seems to be related with the 'fixed-header'.
Assignee: nobody → fbsc
Updated•11 years ago
|
blocking-b2g: --- → leo?
Assignee | ||
Comment 2•11 years ago
|
||
I think this will be fixed by bug 885278 (incidently waiting for a review since 4 days).
Assignee | ||
Comment 3•11 years ago
|
||
Sorry, 5 days now.
Assignee | ||
Comment 4•11 years ago
|
||
Just checked that the fix for Bug 885278 fixes this bug as well.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → DUPLICATE
Assignee | ||
Updated•11 years ago
|
blocking-b2g: leo? → ---
Comment 5•11 years ago
|
||
Sadly bug 885278 was not fixing this issue. I've created a small patch which fix this. As this was part of a bug leo+ that was not fixed completely, I would mark this one as leo+ as well. Leo, could you take a look? Surgical patch which let us close the entire buggy functionality.
Status: RESOLVED → REOPENED
blocking-b2g: --- → leo?
Depends on: 885278
Flags: needinfo?(leo.bugzilla.gaia)
Resolution: DUPLICATE → ---
Comment 6•11 years ago
|
||
Attachment #774579 -
Flags: review?(felash)
Hi Borja, This issue was fixed with the patch available at Bug:885278. But the Bug:890443 was not fixed that patch. Please let me know if you need any information. Thanks,
Flags: needinfo?(leo.bugzilla.gaia)
Assignee | ||
Comment 8•11 years ago
|
||
see also PR at https://github.com/mozilla-b2g/gaia/pull/10941
Assignee: fbsc → felash
Attachment #774579 -
Attachment is obsolete: true
Attachment #774579 -
Flags: review?(felash)
Attachment #774585 -
Flags: review?(fbsc)
Assignee | ||
Comment 9•11 years ago
|
||
The STR for this patch is : * have an empty thread list * send a SMS * go back to the thread list * open the thread * delete the message from the message view * go back to the thread list => the "today" header is still there
Updated•11 years ago
|
Attachment #774585 -
Flags: review?(fbsc) → review+
Comment 10•11 years ago
|
||
Surgical patch and neededin order to have everything related with the header working as expected. Leo we would need to fix this as is a followup of bug 885278 which was leo+ (without this is not working as expected). Could you take a look? Thanks!
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Comment 11•11 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/accb67f7beb3f00f8bcf23337e3ced0795cff4c9 https://github.com/julienw/gaia/commit/0dbbeba6746470cd400b11320bbf1975def4d29e R+.Merged! Thanks Julien for the quick fix.
Comment 12•11 years ago
|
||
this needs leo+ - it blocks a blocker
Comment 14•11 years ago
|
||
John, could you take this uplifting? Now is leo+. THanks!
Flags: needinfo?(jhford)
Comment 15•11 years ago
|
||
v1-train: https://github.com/mozilla-b2g/gaia/commit/f6d1d3221ae5fbb0a576e539d271825658f2652b
status-b2g18:
--- → fixed
status-b2g-v1.1hd:
--- → affected
Updated•11 years ago
|
Flags: needinfo?(jhford)
Comment 16•11 years ago
|
||
This bug is verified fixed with the variables below. When deleting Multiple messages from 1 contact from within the sms thread or from the thread list, the header for TODAY is also deleted. Build ID: 20130722070207 Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/68fb0a2e0114 Gaia: 41d10fb10be6916e6554eb440d9a97130ef23ce0 Platform Version: 18.1 RIL Version: 01.01.00.019.158
Comment 17•11 years ago
|
||
v1.1.0hd: f6d1d3221ae5fbb0a576e539d271825658f2652b
You need to log in
before you can comment on or make changes to this bug.
Description
•