89052 - [imap] Couldn't search headers for "PDT+"

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[selmer (gone)]

7/2 03 win98

I was in a folder containing messages requesting PDT+ approvals
I used the Search menu to get to the search dialog for that folder
I attempted to search (subject contains "a=" OR subject contains "pdt+")

I got an error message "missing required argument to search header"
Removing the "+" from "pdt+" avoids the error, but that's a different search
Searching on *just* (subject contains "pdt+") works fine!

Comment 1

[laurel]

I can get the same error, but only if using the two subject text strings you
specified in order.  If I switch the a= to the second subject field (with pdt+
as first subject string), all is ok. 

Comment 2

[Håkan Waara]

Seth has been working on the Search backend previously. CC sspitzer.

Comment 3

[Navin Gupta]

i will investigate...

Comment 4

[Håkan Waara]

I tried a search for ("pdt+" OR "a=") in both orders, and on Local Folders, my
POP account and in my news account.

I never got the error.

Resolving as worksforme. If this is IMAP-only or still reproducable, feel free
to reopen.

Comment 5

[selmer (gone)]

Håkan, please see Laurel's comment from 7/3.

Comment 6

[Håkan Waara]

I told you, I tried both orders and it worked fine for me. Please retry with a
trunk build.

Comment 7

[Håkan Waara]

worksforme again then, i guess.

Comment 8

[(not reading, please use [e-mail] instead)]

reopening.  this looks like it is imap specific.

Comment 9

[(not reading, please use [e-mail] instead)]

hwaara, if you want a free imap account, check out subdimension.com

Comment 10

[(not reading, please use [e-mail] instead)]

we're missing a quote.

this search works:

"SEARCH UNDELETED (OR HEADER SUBJECT "pdt+" HEADER SUBJECT "a=")"

this search fails:

"SEARCH UNDELETED (OR HEADER SUBJECT "a=" HEADER SUBJECT "pdt+)"

I'll take a quick look into the fix.

Comment 11

[(not reading, please use [e-mail] instead)]

ok, I think I see the problem.

testing a patch.

Comment 12

[(not reading, please use [e-mail] instead)]

Attachment: fix

Comment 13

[(not reading, please use [e-mail] instead)]

the problem was we had some old 4.x code that used to use a byte count mixed in 
with some code that used Length() on a new string type.

the goal of that code is:  if the last char is ' ', truncate so we don't end up 
with 'FOO )', we end up with 'FOO)'

I cleaned it up, please review.

Comment 14

[David :Bienvenu]

r=bienvenu, looks good.

Comment 15

[(not reading, please use [e-mail] instead)]

I could take this a step further and fix GenerateEncodeStr() to not return an 
int, since now it not used.

Comment 16

[Navin Gupta]

r=naving

Comment 17

[(not reading, please use [e-mail] instead)]

fixed.

Comment 18

[(not reading, please use [e-mail] instead)]

Attachment: the complete fix, with cleanup.

Comment 19

[(not reading, please use [e-mail] instead)]

*** Bug 92795 has been marked as a duplicate of this bug. ***

Comment 20

[laurel]

OK using aug06 commercial trunk build win98. Also tried another failure case as
mentioned in 92795. OK. Marking verified.