890525 - Previous projects with html5 media crash FF + Chrome

Status: RESOLVED FIXED

(Webmaker Graveyard :: Popcorn Maker, defect)

Description

[Brett Gaylor [:brett]]

STR:

1) Create a new project using this clip for media http://videos-cdn.mozilla.net/serv/webmademovies/makecorn.webm
2) Save it
3) Log out
4) Log in
5) open up project from myMakes
6) In Firefox, notice the editor dialogues have disappeared.  In Chrome, we crash

Comment 1

[Brett Gaylor [:brett]]

This is the clip the user had in their project:
http://ia601200.us.archive.org/29/items/Children_Must_Learn_The/0883_Children_Must_Learn_The_14_22_40_00_3mb.ogv

We should test with that

Comment 2

[Matthew Schranz [:mjschranz]]

I see where it's failing on the loading of the project.

There is a second problem present however that you can't save a project in Chrome with an HTML5 media clip.

Comment 3

[Matthew Schranz [:mjschranz]]

Filed https://bugzilla.mozilla.org/show_bug.cgi?id=890538

Comment 4

[Matthew Schranz [:mjschranz]]

Wrong ticket!

Comment 5

[Matthew Schranz [:mjschranz]]

Attachment: https://github.com/mozilla/popcorn.webmaker.org/pull/93

Going to dig into a causing commit, but here's a gist of it.

We try sending a VIDEO element to the server inside the clip data for HTML5. Chrome doesn't save properly because it fails setting up the data before then. Firefox saves, but by the time the clip data get's to the server the thumbnail is just an empty object instead of a video element.

Comment 6

[Matthew Schranz [:mjschranz]]

Updated PR.

Comment 7

[[github robot]]

Commit pushed to master at https://github.com/mozilla/popcorn.webmaker.org

https://github.com/mozilla/popcorn.webmaker.org/commit/28f7847b08fd0273aa279e9ff4070558a8c42179
Bug 890525 - Don't save HTML5 thumbnails as video elements

Comment 8

[Matthew Schranz [:mjschranz]]

Waiting to test on Staging and Production before closing.

Comment 9

[Brett Gaylor [:brett]]

Tested in Firefox, works well.  Imported HTML5 media, saved and published project, all worked.

However, opened project above in Chrome and got a crash, see screenshot.
https://dl.dropboxusercontent.com/u/7968133/images/chromehtml5.png

Using this media (as reported by user):
http://ia601200.us.archive.org/29/items/Children_Must_Learn_The/0883_Children_Must_Learn_The_14_22_40_00_3mb.ogv

Comment 10

[Brett Gaylor [:brett]]

So comment above is invalid as this patch hadn't in fact built.

So seeing two errors when I test this:

1) HTML5 clips in chrome and firefox aren't able to be moved and resized
2) Youtube clips seem to have some trouble loading.  I went to youtube and randomly chose this clip: http://www.youtube.com/watch?v=RVeo6QMcbW4 - which failed to load in chrome. I'm getting this error in chrome's developer console:

Blocked a frame with origin "https://www.youtube.com" from accessing a frame with origin "https://popcorn.mofostaging.net". Protocols, domains, and ports must match.

Comment 11

[Brett Gaylor [:brett]]

Note that other clips DID load in chrome, so something particular about that one?  Did load in Firefox.

Comment 12

[Matthew Schranz [:mjschranz]]

I don't know why there is issues with that clip in Chrome. Seems like there might be some separate underlying bug that clip specifically is exposing.

As far as your first point, that has been filed here https://bugzilla.mozilla.org/show_bug.cgi?id=890556

Should we push this up to production? I don't know if production will need a kick as well. At this point we are half way through Saturday (EST) and it seems like there might not be as much benefit.

Comment 13

[Brett Gaylor [:brett]]

Yes, push it to production - seems the issues I found were already existing on production.  Filed my first issue as https://bugzilla.mozilla.org/show_bug.cgi?id=890640

Comment 14

[Matthew Schranz [:mjschranz]]

Looks good to me on production.

Closing as verified.