890566 - Permissions should reset back to default

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Justin Dolske [:Dolske]]

Not sure if this is a flaw in 885366, or existing permissions bug.

1) Visit some site (eg dolske.net)
2) Check doorhanger, no permissions listed
3) Page Info --> Media --> check Block Images from site
...
4) Open new tab for site
5) Check door hanger, permissions show "Load Images: Block"
6) Set to "Allow"
...
7) Open another new tab for site
8) Check door hanger, permissions show "Load Images: Allow"

The results in step 8 persists across a restart. Since allowing image loading is the default, I'd expect restoring "Allow" to make it stop showing up.

Comment 1

[Dão Gottwald [:dao]]

This is how permission persistence works by design. You can see this in the Page Info window by unchecking "use default", closing the window and re-opening it. "use default" will remain unchecked even though the state ("Allow") matches the default state. Also note that if you changed the default state to "Block", the selected option for that site would still be "Allow".

Comment 2

[Dão Gottwald [:dao]]

That said, bug 889835 makes SitePermissions.jsm know about the default states and we could clear permissions when the state selected in the identity popup matches the default state. We just need to decide whether we want that. See also bug 885366 comment 8.

Comment 3

[Dão Gottwald [:dao]]

Attachment: patch

Comment 4

[Justin Dolske [:Dolske]]

Boriss: last call!

Comment 5

[Dão Gottwald [:dao]]

https://hg.mozilla.org/integration/fx-team/rev/d61263a013b3

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d61263a013b3