Closed Bug 890636 Opened 6 years ago Closed 6 years ago

Remove JSOPTION_PCCOUNT

Categories

(Core :: JavaScript Engine, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla25

People

(Reporter: bhackett, Unassigned)

References

Details

Attachments

(1 file)

Attached patch patchSplinter Review
JSOPTION_PCCOUNT is not terribly meaningful.  It is exposed in the browser and only adds instrumentation that is not visible to the user in any way.  It is also a per-context option which should be removed.  The JIT inspector uses a bit on the runtime, rt->profilingScripts, which should be sufficient by itself.  The attached patch removes this option, and makes a couple other changes:

- Supports spewing Ion assembly in opt shell builds with -D.
- Cleans up logic for deciding whether to generate Ion assembly info.
- Fixes things so that -D once again works with asm.js
Attachment #771785 - Flags: review?(jdemooij)
Attachment #771785 - Flags: review?(jdemooij) → review+
https://hg.mozilla.org/mozilla-central/rev/30c5b9ee2bc5
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Depends on: 888898
You need to log in before you can comment on or make changes to this bug.