STR: 1) Add an image event anywhere 2) Attempt to change start/end to anything else 3) Notice that it doesn't change
These steps didn't produce a bug for me. Are there other things I could be missing? Any error logs?
Same. I can't reproduce this. You were there Jon, can you give us more specific details?
Sorry should've been more specific, attempt to change the start/end times in the editor, not on the tray.
I did in the editor. Was changing the times accordingly. I don't see it locally in FF/Chrome or on production. Either I'm missing something, the STR is missing something or this isn't a bug.
This is most definitely a bug: https://dl.dropboxusercontent.com/u/4403845/image-editor-bug.mov
Created attachment 772229 [details] [review] https://github.com/mozilla/popcorn.webmaker.org/pull/100 So our code to "mimic" input type=number was causing this to break these inputs. I don't think I can remove that code since it's still needed for other inputs so I'll just change these to text.
Attachment #772229 - Flags: review?(jon)
Attachment #772229 - Flags: review?(jon) → review+
Commit pushed to master at https://github.com/mozilla/popcorn.webmaker.org https://github.com/mozilla/popcorn.webmaker.org/commit/5df4417b1460afba1bad5f77cbec43d6f2b4d730 Fix Bug 890651 - Work around for Firefox not supporting input type=number was breaking our custom timestamp start/end inputs
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.