890656 - Users aren't notified if a username already exists

Status: RESOLVED FIXED

(Webmaker Graveyard :: Login, defect)

Description

[Jon Buckley [:jbuck]]

STR:

1) Sign in with an email address that does not have a webmaker account associated with it
2) Attempt to claim a domain that already exists
3) No feedback that "this domain already exists"

Comment 1

[Jon Buckley [:jbuck]]

Assigning to Matt, because I think this might be a regression from the loginapi changes.

Comment 2

[Matthew Schranz [:mjschranz]]

Causing commit https://github.com/mozilla/login.webmaker.org/commit/81142e28d621c07e3b4a3416ae2f041dd861e5ba

This added error handling there, but in this case it doesn't check the kind of error.

Comment 3

[Matthew Schranz [:mjschranz]]

Attachment: https://github.com/mozilla/login.webmaker.org/pull/125

Really basic UI but, it's better than the nothing that was there before.

Comment 4

[Pomax]

Comment on attachment 771798 [details] [review]
https://github.com/mozilla/login.webmaker.org/pull/125

the error message needs a tweak, but that err_msg var really bugs me, since we're touching pretty much all the code that uses it here, let's rename it and make it obvious what it's used for.

Comment 5

[Pomax]

Comment on attachment 771798 [details] [review]
https://github.com/mozilla/login.webmaker.org/pull/125

yeah, this works quite well for me.

Comment 6

[[github robot]]

Commit pushed to master at https://github.com/mozilla/login.webmaker.org

https://github.com/mozilla/login.webmaker.org/commit/4d682082525a5a43b796633e28367865bc84f922
Fix Bug 890656 - No notification if username was taken when claiming domain in userbar