Use MOZ_THIS_IN_INITIALIZER_LIST in netwerk/

RESOLVED FIXED in mozilla25

Status

()

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

Trunk
mozilla25
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Created attachment 771833 [details] [diff] [review]
Patch v1
Attachment #771833 - Flags: review?(brian)
Comment on attachment 771833 [details] [diff] [review]
Patch v1

Review of attachment 771833 [details] [diff] [review]:
-----------------------------------------------------------------

This patch includes a lot of unnecessary changes.

Presumably, those changes are a result of alphabetically sorting the #includes. If it has been decided to do that in Necko, then let's do that in another bug/patch. Also, I'd like to see some indication that we (Platform modules, and Necko specifically) have agreed to do so.
Attachment #771833 - Flags: review?(brian) → review-
(Assignee)

Comment 2

6 years ago
Created attachment 771864 [details] [diff] [review]
Patch v2

That's the de facto standard, but sure.
Attachment #771833 - Attachment is obsolete: true
Attachment #771864 - Flags: review?(brian)
Comment on attachment 771864 [details] [diff] [review]
Patch v2

Review of attachment 771864 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.
Attachment #771864 - Flags: review?(brian) → review+
(Assignee)

Comment 4

6 years ago
https://hg.mozilla.org/mozilla-central/rev/235230b0daee
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.