Closed
Bug 890700
Opened 11 years ago
Closed 11 years ago
Use MOZ_THIS_IN_INITIALIZER_LIST in netwerk/
Categories
(Core :: Networking, defect)
Core
Networking
Tracking
()
RESOLVED
FIXED
mozilla25
People
(Reporter: Ms2ger, Assigned: Ms2ger)
Details
Attachments
(1 file, 1 obsolete file)
|
5.70 KB,
patch
|
briansmith
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #771833 -
Flags: review?(brian)
|
||
Comment 1•11 years ago
|
||
Comment on attachment 771833 [details] [diff] [review] Patch v1 Review of attachment 771833 [details] [diff] [review]: ----------------------------------------------------------------- This patch includes a lot of unnecessary changes. Presumably, those changes are a result of alphabetically sorting the #includes. If it has been decided to do that in Necko, then let's do that in another bug/patch. Also, I'd like to see some indication that we (Platform modules, and Necko specifically) have agreed to do so.
Attachment #771833 -
Flags: review?(brian) → review-
|
Assignee | |
Comment 2•11 years ago
|
||
That's the de facto standard, but sure.
Attachment #771833 -
Attachment is obsolete: true
Attachment #771864 -
Flags: review?(brian)
|
|
||
Comment 3•11 years ago
|
||
Comment on attachment 771864 [details] [diff] [review] Patch v2 Review of attachment 771864 [details] [diff] [review]: ----------------------------------------------------------------- Thanks.
Attachment #771864 -
Flags: review?(brian) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/235230b0daee
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in
before you can comment on or make changes to this bug.
Description
•