890714 - Mixed line endings on trunk

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Emanuel Hoogeveen [:ehoogeveen]]

Attachment: Fix mixed line endings

It seems some mixed line endings have snuck into the tree. The majority are in /gfx, and most of the rest are in media/webrtc/.

The attached patch fixes all the .cpp, .c and .h files in the tree that have mixed line endings. It changes them toward their prevailing style, so the changes should be minimal.

Comment 1

[Joe Drew (not getting mail)]

Comment on attachment 771845 [details] [diff] [review]
Fix mixed line endings

I'd rather we change files from Windows to Unix line endings, but I'm not going to r- based on that. Emanuel, feel free to switch those Windows line-ending files to Unix line-endings with a blanket r=joe.

Comment 2

[Emanuel Hoogeveen [:ehoogeveen]]

I'm hesitant to do that because some of these files are pretty big - for instance, /gfx/layers/d3d10/LayerManagerD3D10Effect.h has 16984 lines with only 4 Unix line endings. By replacing them I'd also presumably show up in the hg blame. If you still think it's a good idea I'd rather do it in a follow-up.

Comment 3

[Joe Drew (not getting mail)]

That's fine. Or we can insist that the person who wrote it initially - Bas!!! - fixes it. :)

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ef67c2952365

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/ef67c2952365

Comment 6

[Wan-Teh Chang]

I pushed the security/nss/cmd/lib/ffs.c fix to the NSS hg repository:
https://hg.mozilla.org/projects/nss/rev/0a50deeed71c