Closed Bug 890714 Opened 7 years ago Closed 7 years ago

Mixed line endings on trunk

Categories

(Core :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla25

People

(Reporter: ehoogeveen, Assigned: ehoogeveen)

Details

Attachments

(1 file)

It seems some mixed line endings have snuck into the tree. The majority are in /gfx, and most of the rest are in media/webrtc/.

The attached patch fixes all the .cpp, .c and .h files in the tree that have mixed line endings. It changes them toward their prevailing style, so the changes should be minimal.
Attachment #771845 - Flags: review?
Attachment #771845 - Flags: review?(rjesup)
Attachment #771845 - Flags: review?(joe)
Attachment #771845 - Flags: review?
Attachment #771845 - Flags: review?(rjesup) → review+
Comment on attachment 771845 [details] [diff] [review]
Fix mixed line endings

I'd rather we change files from Windows to Unix line endings, but I'm not going to r- based on that. Emanuel, feel free to switch those Windows line-ending files to Unix line-endings with a blanket r=joe.
Attachment #771845 - Flags: review?(joe) → review+
I'm hesitant to do that because some of these files are pretty big - for instance, /gfx/layers/d3d10/LayerManagerD3D10Effect.h has 16984 lines with only 4 Unix line endings. By replacing them I'd also presumably show up in the hg blame. If you still think it's a good idea I'd rather do it in a follow-up.
Whiteboard: [checkin-needed]
Keywords: checkin-needed
Whiteboard: [checkin-needed]
Assignee: nobody → emanuel.hoogeveen
Status: NEW → ASSIGNED
That's fine. Or we can insist that the person who wrote it initially - Bas!!! - fixes it. :)
https://hg.mozilla.org/mozilla-central/rev/ef67c2952365
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
I pushed the security/nss/cmd/lib/ffs.c fix to the NSS hg repository:
https://hg.mozilla.org/projects/nss/rev/0a50deeed71c
You need to log in before you can comment on or make changes to this bug.