Closed
Bug 890738
Opened 11 years ago
Closed 11 years ago
Use nsAString instead of nsACString in nsIColorPicker
Categories
(Core :: Widget, defect)
Core
Widget
Tracking
()
RESOLVED
FIXED
mozilla25
People
(Reporter: mounir, Assigned: mounir)
References
Details
Attachments
(1 file)
|
2.23 KB,
patch
|
roc
:
superreview+
|
Details | Diff | Splinter Review |
I changed it because the extra bytes are not needed but Arnaud and I find out that this is actually painful in the widget code and we end up doing too many string conversions which isn't worth it simply to save a few bytes on the colour string.
Attachment #771872 -
Flags: superreview?(roc)
|
||
Comment 1•11 years ago
|
||
Bump the iid, please.
|
Assignee | |
Comment 2•11 years ago
|
||
(In reply to Masatoshi Kimura [:emk] from comment #1) > Bump the iid, please. Sure, we could do that but this interface has been added simply to allow other work to go on. Nothing is using it.
Attachment #771872 -
Flags: superreview?(roc) → superreview+
|
|
Assignee | |
Comment 3•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/73a472818f63
Flags: in-testsuite-
Target Milestone: --- → mozilla25
|
||
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/73a472818f63
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•