890753 - [System] Homescreen is not displayed when SMS notification from lockscreen is touched.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Leo]

Attachment: Repro video

Description: Homescreen is not displayed when SMS notification from lockscreen is touched.
Expected: Homescreen is displayed when home button is pressed.
Gaia revision: f2d6ed54a236e6e3b94f0abad9f0dacb8a1cc7b3
Personal email id:  [e-mail]
Frequency rate: 100%


Repro steps:

1. Press power button to screen-off from homescreen. (It has to be from 'homescreen')
2. Use 2nd phone to send sms to 1st phone.
3. Touch the notification on top of lockscreen.
4. Unlock the lockscreen. Then sms app will launch.
5. Press home button and observe it displays only the homescreen background image.

After pressing power button to screen-off and screen-on, it becomes normal.
Please note that it does not reproduce if the step #1 starts from any app, other than homescreen.

Comment 1

[(inactive after 6/18) Alive Kuo [:alive]]

Bad, taken.

Comment 2

[(inactive after 6/18) Alive Kuo [:alive]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/10824

Hmm, I fixed it but I don't know why the original code doesn't work...lemme investigate more.

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 771907 [details]
https://github.com/mozilla-b2g/gaia/pull/10824

Root cause:
Homescreen visibility is turned off via AppWindow.setVisible(),
however, click notification on lockscreen would open the SMS app on top of homescreen,
when the sms app is closed, this time visibility isn't turned on by AppWindow.setVisible thus the hidden class is not removed.

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

master

https://github.com/mozilla-b2g/gaia/commit/00e47a4028ec962a29faa02e73460643e6a03ea3

Comment 5

[Leo]

(In reply to Alive Kuo [:alive] from comment #4)
> master
> 
> https://github.com/mozilla-b2g/gaia/commit/
> 00e47a4028ec962a29faa02e73460643e6a03ea3

Uplift to v1-train? Thanks!

Comment 6

[(inactive after 6/18) Alive Kuo [:alive]]

John ford would do that uplift I think.

Comment 7

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 00e47a4028ec962a29faa02e73460643e6a03ea3 to:
v1-train: 04338f588769f0b0235e02994041bf9335f8cb8d

Comment 8

[John Ford [:jhford] CET/CEST Berlin Time]

v1.1.0hd: 04338f588769f0b0235e02994041bf9335f8cb8d